From: Dhaval Rajeshbhai Shah <DSHAH@xilinx.com>
To: "'Rob Herring'" <robh@kernel.org>
CC: "arnd@arndb.de" <arnd@arndb.de>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "pombredanne@nexb.com" <pombredanne@nexb.com>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "michal.simek@xilinx.com" <michal.simek@xilinx.com>,
        Hyun Kwon <hyunk@xilinx.com>
Subject: RE: [PATCH v2 1/2] Documentation: devicetree: Add DT bindings to
 xlnx_vcu driver
Thread-Topic: [PATCH v2 1/2] Documentation: devicetree: Add DT bindings to
 xlnx_vcu driver
Thread-Index: AQHTb6ShXrCSOTG87k+oK+YnwVi40qNAKkSAgACYATA=
Date: Wed, 13 Dec 2017 05:12:23 +0000
Message-ID: <BY2PR0201MB1879663CDB18630B31A00F2AC1350@BY2PR0201MB1879.namprd02.prod.outlook.com>
References: <20171207104757.GA27343@kroah.com>
 <1512682276-6082-1-git-send-email-dshah@xilinx.com>
 <1512682276-6082-2-git-send-email-dshah@xilinx.com>
 <20171212200703.nxabyfcjbswwbp4v@rob-hp-laptop>
In-Reply-To: <20171212200703.nxabyfcjbswwbp4v@rob-hp-laptop>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d7807e8a-a71b-4459-58c2-08d541e81865
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2017 05:12:23.8275
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0201MB1006
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vBD5CeIj018614
Content-Length: 1604
Lines: 42

Hi Rob,

Thanks a lot for the review.

> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: Tuesday, December 12, 2017 12:07 PM
> To: Dhaval Rajeshbhai Shah <DSHAH@xilinx.com>
> Cc: arnd@arndb.de; gregkh@linuxfoundation.org;
> pombredanne@nexb.com; mark.rutland@arm.com;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> michal.simek@xilinx.com; Hyun Kwon <hyunk@xilinx.com>; Dhaval
> Rajeshbhai Shah <DSHAH@xilinx.com>
> Subject: Re: [PATCH v2 1/2] Documentation: devicetree: Add DT bindings to
> xlnx_vcu driver
> 
> On Thu, Dec 07, 2017 at 01:31:15PM -0800, Dhaval Shah wrote:
> > Add Device Tree binding document for logicoreIP. This logicoreIP
> > provides the isolation between the processing system and programmable
> > logic. Also provides the clock related information.
> >
> > Signed-off-by: Dhaval Shah <dshah@xilinx.com>
> > ---
> > Changes since v2:
> >  * Describe the h/w
> >  * compatible string is updated to make it more specific
> >    based on the logicoreIP version.
> >  * Removed that encoder and decoder child nodes and relatd properties as
> that
> >    will be a separate driver and dts nodes. other team is working on that.
> >  * Updated to use as a single driver.
> >
> >  .../devicetree/bindings/misc/xlnx,vcu.txt          | 31
> ++++++++++++++++++++++
> >  1 file changed, 31 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/misc/xlnx,vcu.txt
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> 
> One nit. Use "dt-bindings: misc: ..." for the subject.
I will update subject line and send you v3 patch set.