Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751042AbdLMHXw (ORCPT ); Wed, 13 Dec 2017 02:23:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:33938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750751AbdLMHXu (ORCPT ); Wed, 13 Dec 2017 02:23:50 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B85B218B1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=krzk@kernel.org X-Google-Smtp-Source: ACJfBosj/nCdb0+fURJPjYRVQ0M+mHCYEOCEfYVH8tybxuWmpwH3YYA7W7UCbmJyv9LLoUUmsHpAJCao/tYh4DtHWFY= MIME-Version: 1.0 In-Reply-To: <20171213014854.GG20051@gangnam.samsung> References: <20171212075815.8683-1-andi.shyti@samsung.com> <20171212130313.GC1072@brancaleone.zhora.eu> <20171213014854.GG20051@gangnam.samsung> From: Krzysztof Kozlowski Date: Wed, 13 Dec 2017 08:23:47 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] spi: s3c64xx: add SPDX identifier To: Andi Shyti Cc: Philippe Ombredanne , Andi Shyti , Kukjin Kim , Mark Brown , linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, LKML , Greg Kroah-Hartman , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1118 Lines: 37 On Wed, Dec 13, 2017 at 2:48 AM, Andi Shyti wrote: > Hi Krzysztof, > >> > Here, this should be as a top line: >> > >> > // SPDX-License-Identifier: GPL-2.0+ >> > >> > >> > So I agree with the SPDX id but also pointing to the use of the C++ // >> > comment style as requested by Linus [1] >> >> Thanks for the reference. I see that Linus prefers converting entire >> comment into // style. I was not arguing about SPDX line but entire >> existing copyright comment which follows it: >> >> > +// >> > +// Copyright (c) 2009 Samsung Electronics Co., Ltd. >> > +// Jaswinder Singh > > it just looks ugly to me to have something like > > // SPDX... > > /* > * Copyright (c)... > * Jasw... > */ > > I would make everything of the '//' style (I've also seen that > this is the trend also in other subsystems), but honestly I don't > really care. If you're strong on not moving entirely in '//' style > then I can resend it with the double comment style. Let's follow Linus' preference - entire commend converted as you did already. Thanks, Krzysztof