Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751480AbdLMIJF (ORCPT ); Wed, 13 Dec 2017 03:09:05 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:36067 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750751AbdLMIJC (ORCPT ); Wed, 13 Dec 2017 03:09:02 -0500 From: Laurent Pinchart To: Dan Murphy Cc: robh+dt@kernel.org, mark.rutland@arm.com, rpurdie@rpsys.net, jacek.anaszewski@gmail.com, pavel@ucw.cz, sakari.ailus@iki.fi, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [RFC PATCH 1/2] dt: bindings: as3645a: Update dt node example with standard Date: Wed, 13 Dec 2017 10:09:04 +0200 Message-ID: <4192002.yKJgEXTVKE@avalon> Organization: Ideas on Board Oy In-Reply-To: <20171212215024.30116-1-dmurphy@ti.com> References: <20171212215024.30116-1-dmurphy@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2358 Lines: 84 Hi Dan, Thank you for the patch. On Tuesday, 12 December 2017 23:50:23 EET Dan Murphy wrote: > Update the DT binding to remove the device name from > the DT parent node as well as removing the device > name from the label. The LED label will be generated > based off the id name stored in the local driver so > the LED function can be indicated in the label DT > entry. > > Also removed the indentation on the example. This makes the patch a bit harder to review and seems to be a matter of style. > Signed-off-by: Dan Murphy > --- > .../devicetree/bindings/leds/ams,as3645a.txt | 36 ++++++++++--------- > 1 file changed, 18 insertions(+), 18 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt > b/Documentation/devicetree/bindings/leds/ams,as3645a.txt index > fc7f5f9f234c..122aa7165cf3 100644 > --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt > +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt > @@ -58,22 +58,22 @@ label : The label of the indicator LED. I believe you should expand the documentation of the label property to detail how it should be formed. It's nice to update the example, but the bindings should be understandable without it. > Example > ======= > > - as3645a@30 { > - compatible = "ams,as3645a"; > - #address-cells = <1>; > - #size-cells = <0>; > - reg = <0x30>; > - flash@0 { > - reg = <0x0>; > - flash-timeout-us = <150000>; > - flash-max-microamp = <320000>; > - led-max-microamp = <60000>; > - ams,input-max-microamp = <1750000>; > - label = "as3645a:flash"; > - }; > - indicator@1 { > - reg = <0x1>; > - led-max-microamp = <10000>; > - label = "as3645a:indicator"; > - }; > +led-controller@30 { This change looks fine to me. > + compatible = "ams,as3645a"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x30>; > + led@0 { What's the rationale for changing the node name here ? It should be explained in the commit message, and in the DT bindings documentation. > + reg = <0x0>; > + flash-timeout-us = <150000>; > + flash-max-microamp = <320000>; > + led-max-microamp = <60000>; > + ams,input-max-microamp = <1750000>; > + label = "flash"; > }; > + led@1 { > + reg = <0x1>; > + led-max-microamp = <10000>; > + label = "indicator"; > + }; > +}; -- Regards, Laurent Pinchart