Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751973AbdLMIYI (ORCPT ); Wed, 13 Dec 2017 03:24:08 -0500 Received: from mail-ma1ind01on0115.outbound.protection.outlook.com ([104.47.100.115]:10591 "EHLO IND01-MA1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751173AbdLMIYD (ORCPT ); Wed, 13 Dec 2017 03:24:03 -0500 From: Dhaval Shah To: pali.rohar@gmail.com, dvhart@infradead.org, andy@infradead.org Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Dhaval Shah Subject: [PATCH] platform/x86: dell-smo8800: Possible unnecessary 'out of memory' message Date: Wed, 13 Dec 2017 13:53:54 +0530 Message-Id: <20171213082354.23273-1-dhaval.shah@softnautics.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [219.65.63.222] X-ClientProxiedBy: MAXPR0101CA0013.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:c::23) To BM1PR0101MB1444.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:20::11) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cf016598-2861-458b-d32a-08d54202dc46 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4603075)(4627115)(201702281549075)(5600026)(4604075)(2017052603307);SRVR:BM1PR0101MB1444; X-Microsoft-Exchange-Diagnostics: 1;BM1PR0101MB1444;3:g9XhHeXAdYuO/7p/d45C6nAHVG3Ncgl091BTXxDXe7LkLLjskR03FvYPNjY9BS7DcVkRn87uHg3RK6OLNf9/WVG3tCuTaVJlvhGAxOOO3zqI38KGf67gTEdFd+P7ut3QezOGqU1SfU6it/CXzNYFEQ/cOfSbmpptCz787vyZ5VfCShL2fBWALzP7WYHkEh4jwxT1/CvIlcTmKkH7nBv+py5EImK+oATkEdM3FaKnQXl3Evbeoj0av25u/uSmD4gi;25:2RNHaqC5iAlSMNlhDpRSTdLGRE5zDr/juuLO1781U7AwDArE/bMcLYdeAxhS9IMc4onRzEslyMY7ucS1lOKG3x42NMpcmGpMgipC3qJ5YohTQ3b8lEGmTpJpPlnUpJmUuznlIn65JN3wJdPLDgqewcYexGUclzxQ5m1sR818aqprbu4VfLZG7JJo3HjrEV0mciifsXdVNH+Jw5BC8SiZA2iyo7WpP0g7Z4CB3sUUvT3RKGKjvP69AbEWKD3t/0sAPsxsXTDjpVro4q9HPrNU6qnj7dzzhMHUHf06H01g1HZJ2eHx2UIx7/6U6Oy7DIXcH7DemE1SEDT3bX3Gy+7SFA==;31:wxna0pqvYBJlBeuk083h+XfaGHOUdUqzppE1vm2vCVKllejXr6mE1Ca2N4JNwFIFid0FulAVVzRMNIddARwBRRo8vYqYKOdVlgwhLwIlKOf6g3pjWJ65m7jmYGWLQOdTIzCsUUa3FHNvtJc1B7sudnXUaSfYrtRqrAo7joLhLdEeS6AK2KrTxVwHr5ylrzZg9AdeZRYSoxmID92+YAcHF83ShG02EyDiyvvwmTyeLcQ= X-MS-TrafficTypeDiagnostic: BM1PR0101MB1444: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=dhaval.shah@softnautics.com; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(3231022)(3002001)(10201501046)(93006095)(93001095)(6041248)(20161123555025)(20161123562025)(2016111802025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(6072148)(6043046)(201708071742011);SRVR:BM1PR0101MB1444;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:BM1PR0101MB1444; X-Microsoft-Exchange-Diagnostics: 1;BM1PR0101MB1444;4:EX0eiZNdwZ0vYHwke9WUKMq42bOnRzJCSvbYoNWHswzBbialDV//3mn7pI85PAvAmh0BjPGmVd6nI78gG2LDTwOX0vXjkF+4Zpg7BoQzGruPG3p6pMrUeQ19TdAXX5PEOpL2iHLVKNTXSIXFpPUJ2GJMwALEEi5vSL35Jym2YZCRWzxfe2MER7uh7mEGOVERtk/ZXeGRf28ZRF8pK+uNWHz30LzRAsG6qEhti99JpfB9kElQLBNNYYIHJOhPjBJAlfbx9GaSmEYq8ZEiMWbL+A== X-Forefront-PRVS: 052017CAF1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(376002)(39830400002)(346002)(366004)(199004)(189003)(6116002)(47776003)(1076002)(16526018)(66066001)(81166006)(8936002)(48376002)(386003)(316002)(106356001)(25786009)(6506007)(50466002)(7736002)(8676002)(81156014)(3846002)(53936002)(36756003)(6666003)(6512007)(5660300001)(4326008)(52116002)(97736004)(478600001)(50226002)(39060400002)(305945005)(68736007)(107886003)(69596002)(6486002)(105586002)(16586007)(51416003)(15650500001)(86362001)(53416004)(2906002);DIR:OUT;SFP:1102;SCL:1;SRVR:BM1PR0101MB1444;H:piyush.sibshivalik.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BM1PR0101MB1444;23:ymMBYv5ITrdAI4P+MNbrWMoB2JoW7P5ICVmh2JU?= =?us-ascii?Q?lr5JY4ZnTMyM5i1HWyQY+3HU0A1+RcvEcoyEyVTJedmd5mppqeEeeWte82Uu?= =?us-ascii?Q?8iPq66c0a2Iti8/+TGj+wlahCokxJxjwIMSDy0tCkDmEqS3MiOeyW0nOSC/8?= =?us-ascii?Q?tvYwrmQVpeO3WPwFsWbT0SXcMH0vJltQoZZyzn1H++rJSD+2P/E1O8mf7SCR?= =?us-ascii?Q?FKgsHzBRDdlbHSczkSYoKeImjbobcytIMT1qo/Y03s/KTnx3wRVYuGg2DN5u?= =?us-ascii?Q?DJeTq+lN9EvZugze+vxm0iGtpq+Ob4SMlg5cY2HUXXf6o+XtA9Ll+9pDLyTl?= =?us-ascii?Q?rxFgrAxNHMIpeG/xHgMzWhsqZjONs0uHcuymhA2sai/m7/T3mJLqueak7HnK?= =?us-ascii?Q?R+2bWolDZfoL0cQcpEUDnnkGjq8sUZbmyKR6BIGUnlcF7NzjgmAG8KjugtZ4?= =?us-ascii?Q?1i78zR5MxOosKoBq59iQhJZv+dWk/VU+8qvSQUcL0a5qauOCCHk3tKu+sgn5?= =?us-ascii?Q?DMK7n86Y69zt2lXjiH5o8GyggG5vphHnjyoYDS7r96RZMHJ7NvXAHICSk3TF?= =?us-ascii?Q?J+ZoCu4TZMTRFfcZd7D4cqJtfImHXx/2yAtjEbX63jraWSFh5fXA0KOdZXKA?= =?us-ascii?Q?9ixOqM1uUxVVPx8HLmDRZ5038kkCXc95/SwbeHyAKokmk1f+Wwl0TPrzj2JI?= =?us-ascii?Q?hcclnNm5bTKrgjyW5OqqqkYAz3l4j7ktiAEXpvxsfQUCf8S744SGmO+OztMi?= =?us-ascii?Q?0SzjgHMZ3hTAqSwX6Rk/23KgVnWDb3ufRBnqKIWGIktBrpZM+4Ije/A3LNeP?= =?us-ascii?Q?gx0zP59N2gsVslMs7xIfjH/99XNCh4ptgMxjs95wF/PbufMF2WHjykTwzRM4?= =?us-ascii?Q?fcj2V9exsqGZE+ec6y+PV+D8QnE6qf+mbSWaPR3Qgwzt30vkTFAMvH2ri07Y?= =?us-ascii?Q?8pcp1G0rKET7BNVPS8nlwp4TdnSJZOw9lRsSu4HC8mOKEpcvUJUgrvo1GJ0p?= =?us-ascii?Q?QlNNL+glxbIzkhpHVIfHTFEy5aUx4st2kPHMeXRAjOBBr01mmzZi5/wLV8Q6?= =?us-ascii?Q?BM6GvCW/+ECk7x+EnTvQJhGBPxXllZg23hhbxFpq9RHVIWvMGWw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BM1PR0101MB1444;6:nDlD2zFaPzhV4jSkVDyr0kUreAd5svwdW3CVmCwFvhj6/F7IbHxl3WKFwu34nRBFa1C00T4xCUyIZue4CX0vuNOh/YhTxEMBtK4vpP57r5BYOA7ZULTPDKFrmyUJJrvT7cYXAV9Nye56MgFrNvz+wlXPX6s8BUCgsu9+q8DSNXzTl4yZ/IqQcxPqKaDWbF4riJkGdzBCQaRUHq9WsxEVpYhHbGePMhz+jdjZFO3JeDwwY9b79x1sJxR/gF3cSCyuHDVNaPc5345/eo7YbzabHI6fQR/Wc1KK/JhFXha+L3HHC7/e8q+Zk1MZwkn7qIZh26DrzLNt9DK21sXzeWrxSY2Uc6Aal700DdERvECasLE=;5:z4hzRSEuN/yajSEHR/AdTXZCmxEG+W5XoLpm74+MkZHXPA/vgOroeaNqUVqHd15RjT4oEErDVUDT8D/X73utT3epwptZBg4scjLIp06qggmBynQ0pRapqc/GQck7f1TPeJq/pIwOc/Ipr16i9FWkHBh15aPpPsZHxJjx69XhRpA=;24:6WLT5yTh3AMiPKXkzI+y7huBax8yhb2HyAuJIIh8zOiSsG8/sR4GsrzV8oqhallxaDUhw71ZJZ3c/e/p7H8qHnfhDT0Xa+1IvQHGxM7R84U=;7:Ybobe/EtoTt9Xn9igVmT6JItt24WQdS+Oevye6PBzT9aCBal/lBsM5HH/foKsoPWTiQmxgSdKOYFDPcIUzALLWm3oAX34rTdrOJK1XhlS9KqwR7r9BzS7/Zcm6U+LLtzaF79J+8OF1osyGhvINg89ch8Zl4KbELfBN8/IYmMShkbrigZhumi/p8rj2sasV31QfFbiO2+TKogycw2zXWYBuwZ5moz9HVZfKc+7mGgRkJ9wgZqfLdkb5svKqc9r86Y SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: softnautics.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2017 08:23:58.8446 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cf016598-2861-458b-d32a-08d54202dc46 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 17b76cff-50c6-4f7a-9198-dd4afc5f8bea X-MS-Exchange-Transport-CrossTenantHeadersStamped: BM1PR0101MB1444 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 857 Lines: 26 Removed Possible unnecessary 'out of memory' message checkpatch warnings. Issue found by checkpatch. Signed-off-by: Dhaval Shah --- drivers/platform/x86/dell-smo8800.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/platform/x86/dell-smo8800.c b/drivers/platform/x86/dell-smo8800.c index 1d87237bc731..9590d5e7c5ca 100644 --- a/drivers/platform/x86/dell-smo8800.c +++ b/drivers/platform/x86/dell-smo8800.c @@ -150,10 +150,8 @@ static int smo8800_add(struct acpi_device *device) struct smo8800_device *smo8800; smo8800 = devm_kzalloc(&device->dev, sizeof(*smo8800), GFP_KERNEL); - if (!smo8800) { - dev_err(&device->dev, "failed to allocate device data\n"); + if (!smo8800) return -ENOMEM; - } smo8800->dev = &device->dev; smo8800->miscdev.minor = MISC_DYNAMIC_MINOR; -- 2.11.0