Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751933AbdLMIa7 (ORCPT ); Wed, 13 Dec 2017 03:30:59 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:46765 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751880AbdLMIa4 (ORCPT ); Wed, 13 Dec 2017 03:30:56 -0500 X-Google-Smtp-Source: ACJfBotmRd4Ww/ib9xkfOWsVLst+c3ugMurbG0Vg4NEjDQz0uAQh7KcLSJtiItUnARQzza5bQGOUpg== Date: Wed, 13 Dec 2017 09:30:53 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Dhaval Shah Cc: dvhart@infradead.org, andy@infradead.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] platform/x86: dell-smo8800: Possible unnecessary 'out of memory' message Message-ID: <20171213083053.mywa4bgv56daxud6@pali> References: <20171213082354.23273-1-dhaval.shah@softnautics.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171213082354.23273-1-dhaval.shah@softnautics.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1046 Lines: 32 On Wednesday 13 December 2017 13:53:54 Dhaval Shah wrote: > Removed Possible unnecessary 'out of memory' message checkpatch warnings. > Issue found by checkpatch. > > Signed-off-by: Dhaval Shah > --- > drivers/platform/x86/dell-smo8800.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/dell-smo8800.c b/drivers/platform/x86/dell-smo8800.c > index 1d87237bc731..9590d5e7c5ca 100644 > --- a/drivers/platform/x86/dell-smo8800.c > +++ b/drivers/platform/x86/dell-smo8800.c > @@ -150,10 +150,8 @@ static int smo8800_add(struct acpi_device *device) > struct smo8800_device *smo8800; > > smo8800 = devm_kzalloc(&device->dev, sizeof(*smo8800), GFP_KERNEL); > - if (!smo8800) { > - dev_err(&device->dev, "failed to allocate device data\n"); Hi! Any particular reason for removing error message? > + if (!smo8800) > return -ENOMEM; > - } > > smo8800->dev = &device->dev; > smo8800->miscdev.minor = MISC_DYNAMIC_MINOR; -- Pali Rohár pali.rohar@gmail.com