Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751504AbdLMIsD (ORCPT ); Wed, 13 Dec 2017 03:48:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36540 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750795AbdLMIsB (ORCPT ); Wed, 13 Dec 2017 03:48:01 -0500 Date: Wed, 13 Dec 2017 09:47:55 +0100 From: Cornelia Huck To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, christoffer.dall@linaro.org, James Hogan , Paul Mackerras , Christian Borntraeger Subject: Re: [PATCH] KVM: introduce kvm_arch_vcpu_async_ioctl Message-ID: <20171213094755.428f8f26.cohuck@redhat.com> In-Reply-To: <1513099915-107126-1-git-send-email-pbonzini@redhat.com> References: <1513099915-107126-1-git-send-email-pbonzini@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 13 Dec 2017 08:48:01 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1146 Lines: 28 On Tue, 12 Dec 2017 18:31:55 +0100 Paolo Bonzini wrote: > After the vcpu_load/vcpu_put pushdown, the handling of asynchronous VCPU > ioctl is already much clearer in that it is obvious that they bypass > vcpu_load and vcpu_put. > > However, it is still not perfect in that the different state of the VCPU > mutex is still hidden in the caller. Separate those ioctls into a new > function kvm_arch_vcpu_async_ioctl that returns -ENOIOCTLCMD for more > "traditional" synchronous ioctls. > > Cc: James Hogan > Cc: Paul Mackerras > Cc: Christian Borntraeger > Suggested-by: Cornelia Huck > Signed-off-by: Paolo Bonzini > --- > arch/mips/kvm/mips.c | 15 ++++++++++++--- > arch/powerpc/kvm/powerpc.c | 14 +++++++++++--- > arch/s390/kvm/kvm-s390.c | 16 ++++++++++++---- > include/linux/kvm_host.h | 2 ++ > virt/kvm/kvm_main.c | 8 ++++---- > 5 files changed, 41 insertions(+), 14 deletions(-) Another vote for a dummy function here, but otherwise Reviewed-by: Cornelia Huck