From: Dhaval Shah <dhaval.shah@softnautics.com>
To: Philippe Ombredanne <pombredanne@nexb.com>
CC: "pali.rohar@gmail.com" <pali.rohar@gmail.com>,
        Darren Hart <dvhart@infradead.org>,
        Andy Shevchenko <andy@infradead.org>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: dell-rbtn: Block comments use * on
 subsequent lines
Thread-Topic: [PATCH] platform/x86: dell-rbtn: Block comments use * on
 subsequent lines
Thread-Index: AQHTc+ueO0Cna25wN0e/W2phGgOFfqNBAKSAgAAFUfQ=
Date: Wed, 13 Dec 2017 09:52:32 +0000
Message-ID: <BM1PR0101MB1444C78FDA61BA59D578A5F8E6350@BM1PR0101MB1444.INDPRD01.PROD.OUTLOOK.COM>
References: <20171213082301.23209-1-dhaval.shah@softnautics.com>,<CAOFm3uEP-fGPiZt96QDvgXG1Ws8WgdFLbOsGumvhGSG-e7L0Ng@mail.gmail.com>
In-Reply-To: <CAOFm3uEP-fGPiZt96QDvgXG1Ws8WgdFLbOsGumvhGSG-e7L0Ng@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c3df7904-8e92-4d68-3100-08d5420f3b63
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2017 09:52:32.9998
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 17b76cff-50c6-4f7a-9198-dd4afc5f8bea
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BM1PR0101MB1443
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vBD9qkmX023895
Content-Length: 3222
Lines: 74

HI

Thanks a lot for the review.
________________________________________
> From: Philippe Ombredanne <pombredanne@nexb.com>
> Sent: Wednesday, December 13, 2017 2:54 PM
> To: Dhaval Shah
> Cc: pali.rohar@gmail.com; Darren Hart; Andy Shevchenko; platform-driver-x86@vger.kernel.org; LKML
> Subject: Re: [PATCH] platform/x86: dell-rbtn: Block comments use * on subsequent lines
> 
> Dhaval,
> 
> On Wed, Dec 13, 2017 at 9:23 AM, Dhaval Shah
> <dhaval.shah@softnautics.com> wrote:
> > Resolved Block comments use * on subsequent lines checkpatch warnings.
> > Issue found by checkpatch.
> >
> > Signed-off-by: Dhaval Shah <dhaval.shah@softnautics.com>
> > ---
> >  drivers/platform/x86/dell-rbtn.c | 26 +++++++++++++-------------
> >  drivers/platform/x86/dell-rbtn.h | 26 +++++++++++++-------------
> >  2 files changed, 26 insertions(+), 26 deletions(-)
> >
> > diff --git a/drivers/platform/x86/dell-rbtn.c b/drivers/platform/x86/dell-rbtn.c
> > index f3afe778001e..cab93c6dcd34 100644
> > --- a/drivers/platform/x86/dell-rbtn.c
> > +++ b/drivers/platform/x86/dell-rbtn.c
> > @@ -1,17 +1,17 @@
> >  /*
> > -    Dell Airplane Mode Switch driver
> > -    Copyright (C) 2014-2015  Pali Roh?r <pali.rohar@gmail.com>
> > -
> > -    This program is free software; you can redistribute it and/or modify
> > -    it under the terms of the GNU General Public License as published by
> > -    the Free Software Foundation; either version 2 of the License, or
> > -    (at your option) any later version.
> > -
> > -    This program is distributed in the hope that it will be useful,
> > -    but WITHOUT ANY WARRANTY; without even the implied warranty of
> > -    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > -    GNU General Public License for more details.
> > -*/
> > + *   Dell Airplane Mode Switch driver
> > + *   Copyright (C) 2014-2015  Pali Roh?r <pali.rohar@gmail.com>
> > + *
> > + *   This program is free software; you can redistribute it and/or modify
> > + *   it under the terms of the GNU General Public License as published by
> > + *   the Free Software Foundation; either version 2 of the License, or
> > + *   (at your option) any later version.
> > + *
> > + *   This program is distributed in the hope that it will be useful,
> > + *   but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + *   GNU General Public License for more details.
> > + */
> 
> Do you mind using the new SPDX ids instead of this long legalese?
> You can check the doc patches from Thomas for details [1]
> 
> 
> [1] https://lkml.org/lkml/2017/12/4/934
This is different issue. If we need to fix the issue of this if we update SPDX licensing as well.
I am agree with you on the use of the new SPDX IDs instead of the long legalese.
For this, we have to add the text "// SPDX-License-Identifier: GPL-2.0" at the top of the file and remove the 
whole license part and keep on copyright and Author name related info. After change, it looks like
// SPDX-License-Identifier: GPL-2.0
/*
 *  Dell Airplane Mode Switch driver
 *  Copyright (C) 2014-2015  Pali Roh?r <pali.rohar@gmail.com>
 */
 
> --
> Cordially
> Philippe Ombredanne