Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752565AbdLMKOW (ORCPT ); Wed, 13 Dec 2017 05:14:22 -0500 Received: from mga02.intel.com ([134.134.136.20]:38555 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751508AbdLMKOM (ORCPT ); Wed, 13 Dec 2017 05:14:12 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,397,1508828400"; d="scan'208";a="11928720" Date: Wed, 13 Dec 2017 13:13:36 +0300 From: "Kirill A. Shutemov" To: "Aneesh Kumar K.V" Cc: Andrew Morton , Vlastimil Babka , Vineet Gupta , Russell King , Will Deacon , Catalin Marinas , Ralf Baechle , "David S. Miller" , Martin Schwidefsky , Heiko Carstens , Andrea Arcangeli , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv3 11/11] mm: Use updated pmdp_invalidate() interface to track dirty/accessed bits Message-ID: <20171213101336.np2tin32o5ppvion@black.fi.intel.com> References: <20170912153941.47012-1-kirill.shutemov@linux.intel.com> <20170912153941.47012-12-kirill.shutemov@linux.intel.com> <87tw07uz7p.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87tw07uz7p.fsf@linux.vnet.ibm.com> User-Agent: NeoMutt/20170714-126-deb55f (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 580 Lines: 17 On Wed, Sep 13, 2017 at 02:08:58AM +0000, Aneesh Kumar K.V wrote: > @@ -2011,6 +2036,8 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd, > if (soft_dirty) > entry = pte_mksoft_dirty(entry); > } > + if (dirty) > + SetPageDirty(page + i); > pte = pte_offset_map(&_pmd, addr); > BUG_ON(!pte_none(*pte)); > set_pte_at(mm, addr, pte, entry); The patch is fine. But we don't need to set every 4k dirty. We have single dirty bit for whole THP. I'll change this part and sent the patch as part of the series. -- Kirill A. Shutemov