Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752646AbdLMKfY (ORCPT <rfc822;w@1wt.eu>);
        Wed, 13 Dec 2017 05:35:24 -0500
Received: from lhrrgout.huawei.com ([194.213.3.17]:11684 "EHLO huawei.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1752275AbdLMKfU (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 13 Dec 2017 05:35:20 -0500
From: Salil Mehta <salil.mehta@huawei.com>
To: Philippe Ombredanne <pombredanne@nexb.com>
CC: "David S. Miller" <davem@davemloft.net>,
        "Zhuangyuzeng (Yisen)" <yisen.zhuang@huawei.com>,
        "lipeng (Y)" <lipeng321@huawei.com>,
        Salil Mehta <mehta.salil.lnk@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        Linuxarm <linuxarm@huawei.com>
Subject: RE: [PATCH V3 net-next 3/8] net: hns3: Add HNS3 VF HCL(Hardware
 Compatibility Layer) Support
Thread-Topic: [PATCH V3 net-next 3/8] net: hns3: Add HNS3 VF HCL(Hardware
 Compatibility Layer) Support
Thread-Index: AQHTc3ITLfqhoPwWVE6ioSggI1os26NAPNmAgADQBqA=
Date: Wed, 13 Dec 2017 10:35:10 +0000
Message-ID: <F4CC6FACFEB3C54C9141D49AD221F7F93BB76189@FRAEML521-MBX.china.huawei.com>
References: <20171212175205.236-1-salil.mehta@huawei.com>
 <20171212175205.236-4-salil.mehta@huawei.com>
 <CAOFm3uGs2yO4jfFZSVzZMbE6cbgzzkSBDPFAO_fbt-1XKx7FpQ@mail.gmail.com>
In-Reply-To: <CAOFm3uGs2yO4jfFZSVzZMbE6cbgzzkSBDPFAO_fbt-1XKx7FpQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.202.226.117]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id vBDAZSp3028360
Content-Length: 3797
Lines: 120

Hi Philippe,

> -----Original Message-----
> From: Philippe Ombredanne [mailto:pombredanne@nexb.com]
> Sent: Tuesday, December 12, 2017 10:41 PM
> To: Salil Mehta <salil.mehta@huawei.com>
> Cc: David S. Miller <davem@davemloft.net>; Zhuangyuzeng (Yisen)
> <yisen.zhuang@huawei.com>; lipeng (Y) <lipeng321@huawei.com>; Salil
> Mehta <mehta.salil.lnk@gmail.com>; netdev@vger.kernel.org; LKML <linux-
> kernel@vger.kernel.org>; linux-rdma@vger.kernel.org; Linuxarm
> <linuxarm@huawei.com>
> Subject: Re: [PATCH V3 net-next 3/8] net: hns3: Add HNS3 VF
> HCL(Hardware Compatibility Layer) Support
> 
> Dear Salil,
> 
> On Tue, Dec 12, 2017 at 6:52 PM, Salil Mehta <salil.mehta@huawei.com>
> wrote:
> > This patch adds the support of hardware compatibiltiy layer to the
> > HNS3 VF Driver. This layer implements various {set|get} operations
> > over MAC address for a virtual port, RSS related configuration,
> > fetches the link status info from PF, does various VLAN related
> > configuration over the virtual port, queries the statistics from
> > the hardware etc.
> >
> > This layer can directly interact with hardware through the
> > IMP(Integrated Mangement Processor) interface or can use mailbox
> > to interact with the PF driver.
> >
> > Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
> > Signed-off-by: lipeng <lipeng321@huawei.com>
> > ---
> > Patch V3: Addressed SPDX change requested by Philippe Ombredanne
> >   Link: https://lkml.org/lkml/2017/12/8/874
> > Patch V2: Addressed some internal comments
> > Patch V1: Initial Submit
> > ---
> >  .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c  | 1490
> ++++++++++++++++++++
> >  .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h  |  164 +++
> >  2 files changed, 1654 insertions(+)
> >  create mode 100644
> drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
> >  create mode 100644
> drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h
> >
> > diff --git
> a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
> b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
> > new file mode 100644
> > index 0000000..ff55f4c
> > --- /dev/null
> > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
> > @@ -0,0 +1,1490 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (c) 2016-2017 Hisilicon Limited.
> > + */
> 
> This is just me nitpicking and this is entirely up to you.... but in
> such a simple case you could go all the way too:
> 
> > +// SPDX-License-Identifier: GPL-2.0+
> > +// Copyright (c) 2016-2017 Hisilicon Limited.
> 
> In this case this can make the thing look more consistent.
Ok I can do that, no issues with that.

As such, I changed according to Jonathan Corbet's article on LWN.
https://lwn.net/Articles/739183/
and also searched the SPDX identifier usage in the existing kernel
and I can see community following different ways including

(*) For Kernel C files:

// SPDX-License-Identifier: GPL-2.0+
// Copyright (c) 2016-2017 Hisilicon Limited. 

OR

// SPDX-License-Identifier: GPL-2.0+
/*
 * Copyright (c) 2016-2017 Hisilicon Limited.
 */

OR

// SPDX-License-Identifier: GPL-2.0+

(*) For Kernel h files:

/* SPDX-License-Identifier: GPL-2.0+ */
/* Copyright (c) 2016-2017 Hisilicon Limited. */

(*) For Makefiles

# SPDX-License-Identifier: GPL-2.0+

OR

# id: Makefile
# SPDX-License-Identifier: GPL-2.0+


I could also make out from different articles, including from the below,
Linus suggesting moving to "//" type instead of starred ones for headers.

It looks SPDX change is still a suggestion?


> See also Linus commentaries about this [1][2][3][4]
> 
> [1] https://lkml.org/lkml/2017/11/25/133
> [2] https://lkml.org/lkml/2017/11/25/125
> [3] https://lkml.org/lkml/2017/11/2/715
> [4] https://lkml.org/lkml/2017/11/2/805
Sure, thanks.


Salil