Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752366AbdLMKhb (ORCPT ); Wed, 13 Dec 2017 05:37:31 -0500 Received: from mail-vk0-f68.google.com ([209.85.213.68]:33732 "EHLO mail-vk0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751508AbdLMKh2 (ORCPT ); Wed, 13 Dec 2017 05:37:28 -0500 X-Google-Smtp-Source: ACJfBotpHIVmOvGI4X/Ve4mlZHoS2i0ZEnAAFILR4ddM7lGkrco/63gwl3OK61n8Cf1JWJ0a0gGVCvOiht1sxD5u7g8= MIME-Version: 1.0 In-Reply-To: <20171212205439.ijhvzmsumiu3l5pp@rob-hp-laptop> References: <1512740801-21142-1-git-send-email-geert+renesas@glider.be> <20171212205439.ijhvzmsumiu3l5pp@rob-hp-laptop> From: Ivo Sieben Date: Wed, 13 Dec 2017 11:37:27 +0100 Message-ID: Subject: Re: [PATCH v2] eeprom: at25: Add DT support for EEPROMs with odd address bits To: Rob Herring Cc: Geert Uytterhoeven , Mark Rutland , Arnd Bergmann , Greg Kroah-Hartman , Wolfram Sang , devicetree@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1179 Lines: 28 2017-12-12 21:54 GMT+01:00 Rob Herring : > On Fri, Dec 08, 2017 at 02:46:41PM +0100, Geert Uytterhoeven wrote: >> Certain EEPROMS have a size that is larger than the number of address >> bytes would allow, and store the MSB of the address in bit 3 of the >> instruction byte. >> >> This can be described in platform data using EE_INSTR_BIT3_IS_ADDR, or >> in DT using the obsolete legacy "at25,addr-mode" property. >> But currently there exists no non-deprecated way to describe this in DT. >> >> Hence extend the existing "address-width" DT property to allow >> specifying 9 address bits, and enable support for that in the driver. >> >> This has been tested with a Microchip 25LC040A. >> >> Signed-off-by: Geert Uytterhoeven >> --- >> v2: >> - Do not consider odd address widths of 17 or 25 bits, >> - Move handling inside the switch() statement. >> --- >> Documentation/devicetree/bindings/eeprom/at25.txt | 4 +++- >> drivers/misc/eeprom/at25.c | 3 +++ >> 2 files changed, 6 insertions(+), 1 deletion(-) > > Reviewed-by: Rob Herring Reviewed-by: Ivo Sieben