Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752826AbdLMLYq (ORCPT ); Wed, 13 Dec 2017 06:24:46 -0500 Received: from mail-lf0-f48.google.com ([209.85.215.48]:46536 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752770AbdLMLYo (ORCPT ); Wed, 13 Dec 2017 06:24:44 -0500 X-Google-Smtp-Source: ACJfBosRcAfiQywTksiu0ovhzVzYe3Mh1g9jdi3tJUVR2JGVhKv+MruM23ye/Gp9F76/lhlX9nITjg== Date: Wed, 13 Dec 2017 12:24:45 +0100 From: Johan Hovold To: Mikhail Zaytsev Cc: Johan Hovold , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: serial: ark3116.c: Remove unused TIOCSSERIAL case from ioctl Message-ID: <20171213112445.GB3831@localhost> References: <20171213123004.4619000a@zaytsev.tver.pg> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213123004.4619000a@zaytsev.tver.pg> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 358 Lines: 10 On Wed, Dec 13, 2017 at 12:30:04PM +0300, Mikhail Zaytsev wrote: > The patch removes unused TIOCSSERIAL case from ioctl. TIOCGSERIAL case > moves to the get_serial_info() function. Some magic numbers moves to > #define directives. You need to split logical changes up in separate patches, and there's at least three things being done here. Thanks, Johan