Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752786AbdLMMBo (ORCPT ); Wed, 13 Dec 2017 07:01:44 -0500 Received: from mail-oi0-f65.google.com ([209.85.218.65]:39533 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752175AbdLMMBm (ORCPT ); Wed, 13 Dec 2017 07:01:42 -0500 X-Google-Smtp-Source: ACJfBova/XLtB3qDRSSV+TfBEn4Bf9ybr0ROPcCkShBmjMn5IEAg5rfwVT5m/pgQrb6FPMlW3eeXc5lV+qpwST3CJ64= MIME-Version: 1.0 In-Reply-To: References: <1513139666-10805-1-git-send-email-wanpeng.li@hotmail.com> From: Wanpeng Li Date: Wed, 13 Dec 2017 20:01:41 +0800 Message-ID: Subject: Re: [PATCH v2] KVM: X86: Fix load bad host fpu state To: David Hildenbrand Cc: "linux-kernel@vger.kernel.org" , kvm , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Wanpeng Li , Rik van Riel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 642 Lines: 17 2017-12-13 17:59 GMT+08:00 David Hildenbrand : > >> if (unlikely(vcpu->arch.mp_state == KVM_MP_STATE_UNINITIALIZED)) { >> @@ -7709,6 +7706,7 @@ int kvm_arch_vcpu_ioctl_set_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu) >> static void fx_init(struct kvm_vcpu *vcpu) >> { >> fpstate_init(&vcpu->arch.guest_fpu.state); >> + fpstate_init(&vcpu->arch.user_fpu.state); > > Won't at least one of them trigger the WARN in fpstate_init? Nothing trigger the WARN during my testing on a Skylake box. And I will not continue to push this one since there is an alternative solution in kvm/queue. Regards, Wanpeng Li