Date: Wed, 13 Dec 2017 15:30:27 +0300
From: Mikhail Zaytsev <flashed@mail.ru>
To: Oliver Neukum <oneukum@suse.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] USB: serial: ark3116.c: Remove unused TIOCSSERIAL case
 from ioctl
Message-ID: <20171213153027.7aaab62b@zaytsev.tver.pg>
In-Reply-To: <1513165248.26281.11.camel@suse.com>
References: <20171213123004.4619000a@zaytsev.tver.pg>
        <1513160248.26281.5.camel@suse.com>
        <20171213143142.1c312b57@zaytsev.tver.pg>
        <1513165248.26281.11.camel@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 616
Lines: 17

On Wed, 13 Dec 2017 12:40:48 +0100 Oliver Neukum <oneukum@suse.com> wrote:

> They give you nothing. If you are looking at a vendor ID nothing but the
> bare number makes sense. You are just making peoples' life harder when
> they have to look up that definition. A symbolic name is fine if it gives
> meaning. Even if the information you give is that the value is magic
> and therefore not understood. But a vendor ID is an arbitrary yet
> meaningful number. There is no point in hiding it.

Thanks. I hear you, Oliver. What about:

-		serstruct.baud_base = 460800;

Is it a magic number? I think yes.

-- 
Mikhail