From: Dhaval Shah <dhaval.shah@softnautics.com>
To: Joe Perches <joe@perches.com>,
        Philippe Ombredanne <pombredanne@nexb.com>
CC: "pali.rohar@gmail.com" <pali.rohar@gmail.com>,
        Darren Hart <dvhart@infradead.org>,
        Andy Shevchenko <andy@infradead.org>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: dell-rbtn: Block comments use * on
 subsequent lines
Thread-Topic: [PATCH] platform/x86: dell-rbtn: Block comments use * on
 subsequent lines
Thread-Index: AQHTc+ueO0Cna25wN0e/W2phGgOFfqNBAKSAgAAFUfSAAATwgIAAC56BgAAcd4CAAALy2Q==
Date: Wed, 13 Dec 2017 12:41:03 +0000
Message-ID: <BM1PR0101MB1444566FE5F5FB785ED97B28E6350@BM1PR0101MB1444.INDPRD01.PROD.OUTLOOK.COM>
References: <20171213082301.23209-1-dhaval.shah@softnautics.com>
         <CAOFm3uEP-fGPiZt96QDvgXG1Ws8WgdFLbOsGumvhGSG-e7L0Ng@mail.gmail.com>
         <BM1PR0101MB1444C78FDA61BA59D578A5F8E6350@BM1PR0101MB1444.INDPRD01.PROD.OUTLOOK.COM>
        ,<CAOFm3uGEmR9Wq1O06CiaqncA4E7mxfgDm97NetOe0qL_mtpsSw@mail.gmail.com>
         <e482b906981f4b46b2336bebba28888bBM1PR0101MB144449CA7ADDBA3A03061AAFE6350@BM1PR0101MB1444.INDPRD01.PROD.OUTLOOK.COM>,<1513167907.27409.3.camel@perches.com>
In-Reply-To: <1513167907.27409.3.camel@perches.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e974ffdd-cb41-41cf-a55d-08d54226c5aa
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2017 12:41:03.4809
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 17b76cff-50c6-4f7a-9198-dd4afc5f8bea
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BM1PR0101MB1443
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vBDCfEKv015567
Content-Length: 2013
Lines: 41

Hi Joe,

________________________________________
> From: Joe Perches <joe@perches.com>
> Sent: Wednesday, December 13, 2017 5:55 PM
> To: Dhaval Shah; Philippe Ombredanne
> Cc: pali.rohar@gmail.com; Darren Hart; Andy Shevchenko; platform-driver-x86@vger.kernel.org; LKML
> Subject: Re: [PATCH] platform/x86: dell-rbtn: Block comments use * on subsequent lines
> 
> On Wed, 2017-12-13 at 10:53 +0000, Dhaval Shah wrote:
> > > > This is different issue. If we need to fix the issue of this if we update SPDX licensing as well.
> > > > I am agree with you on the use of the new SPDX IDs instead of the long legalese.
> > > > For this, we have to add the text "// SPDX-License-Identifier: GPL-2.0" at the top of the file and remove the
> > > > whole license part and keep on copyright and Author name related info. After change, it looks like
> > > > // SPDX-License-Identifier: GPL-2.0
> > > > /*
> > > >   *  Dell Airplane Mode Switch driver
> > > >   *  Copyright (C) 2014-2015  Pali Roh?r <pali.rohar@gmail.com>
> > > >   */
> > >
> > > And for a short comment block like this, Linus preference is to avoid
> > > mixing comment style and go all the way C++ style as in:
> > >
> > > > // SPDX-License-Identifier: GPL-2.0
> > > > // Dell Airplane Mode Switch driver
> > > // Copyright (C) 2014-2015  Pali Roh?r <pali.rohar@gmail.com>
> > >
> > > ... for even less boilerplate ;)
> >
> > Thanks a lot for the link.
> > Do you want to me to update along with SPDX in this patchset with V2 or we will update in the next patchset once this > > >patch merge?
> 
> If anyone does conversions of these license texts
> you have to be _extremely_ careful about what
> specific license identifier you use.

> This license includes the text
>         "or (at your option) any later version"
> which is not the same as using
>         SPDX-License-Identifier: GPL-2.0
I have given this SPDX ID based on the current license info in the driver. Yeah. I give the authority to author pali.rohar@gmail.com to decide the SPDX text.