Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753120AbdLMM6A (ORCPT ); Wed, 13 Dec 2017 07:58:00 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:32873 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753036AbdLMM55 (ORCPT ); Wed, 13 Dec 2017 07:57:57 -0500 X-Google-Smtp-Source: ACJfBovDZus63bCF3qsc8y+9JvnlOVArvEmj9g44+EpZWDXFdqFcVvsyXPBG209mVoaG9r21u0qCrhnWqIaU2mTvOgc= MIME-Version: 1.0 In-Reply-To: References: <20171213082301.23209-1-dhaval.shah@softnautics.com> From: Philippe Ombredanne Date: Wed, 13 Dec 2017 13:57:15 +0100 Message-ID: Subject: Re: [PATCH] platform/x86: dell-rbtn: Block comments use * on subsequent lines To: Dhaval Shah Cc: "pali.rohar@gmail.com" , Darren Hart , Andy Shevchenko , "platform-driver-x86@vger.kernel.org" , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vBDCw5aO020635 Content-Length: 777 Lines: 25 Dhaval, On Wed, Dec 13, 2017 at 11:47 AM, Dhaval Shah wrote: > > And for a short comment block like this, Linus preference is to avoid > > mixing comment style and go all the way C++ style as in: > > > > > // SPDX-License-Identifier: GPL-2.0 > > > // Dell Airplane Mode Switch driver > > > // Copyright (C) 2014-2015 Pali Rohár > > > > > > ... for even less boilerplate ;) > > Thanks a lot for the link. > Do you want to me to update along with SPDX in this patchset with V2 or we will update in the next patchset once this patch merge? That's not for me to decide, I am just a lowly licensing elf helper scruffy! PS: you might want to avoid sending HTML email on lkml, FWIW. -- Cordially Philippe Ombredanne