Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753150AbdLMNIp (ORCPT ); Wed, 13 Dec 2017 08:08:45 -0500 Received: from mail-ma1ind01on0126.outbound.protection.outlook.com ([104.47.100.126]:59296 "EHLO IND01-MA1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752932AbdLMNIm (ORCPT ); Wed, 13 Dec 2017 08:08:42 -0500 From: Dhaval Shah To: Philippe Ombredanne CC: "pali.rohar@gmail.com" , Darren Hart , Andy Shevchenko , "platform-driver-x86@vger.kernel.org" , LKML Subject: Re: [PATCH] platform/x86: dell-rbtn: Block comments use * on subsequent lines Thread-Topic: [PATCH] platform/x86: dell-rbtn: Block comments use * on subsequent lines Thread-Index: AQHTc+ueO0Cna25wN0e/W2phGgOFfqNBAKSAgAAFUfSAAATwgIAAC56BgAAlcoCAAAKQMQ== Date: Wed, 13 Dec 2017 13:08:37 +0000 Message-ID: References: <20171213082301.23209-1-dhaval.shah@softnautics.com> , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dhaval.shah@softnautics.com; x-originating-ip: [219.65.63.222] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BM1PR0101MB1442;6:M2yctgbJUVLtzEGNDGe7ooDDfqZetj25iJs/RN5LTvi0sYVNxQqpChBgie3adVwFrv1MqRKpjfbUN9LSXM6eCEen8WtkuYCzcFbG9Kdn/HTsLimV5/nRZM+Vg78PbfZ0c4uvV8E99wvTT51CmMUFbHmU37Sy+z94J5VzoyytD26vq8WpT4NBtXbl0xuXith5mU/TaAX9GFwRD1/GABGO60DQ6T2K5POQVnNCLTrEkZ8ndQpUHdS7GLeYK3UyWLdbHgGWZs2vMjDfbt4cNSlpgOick97jGTkB+K8SIMrkl62ny5XZ01IBH3Oiog3hzHOykBQFEmm52E3SObpWs69HwPyzseSZ45GCJYPweJMauo8=;5:PIibmx1aAhqHjm+dYoL/DkAcRhpZGij/Dl6YZ3EY6nUUPRAeI6ija0WPoR37/Ya80XZgAkfkTDpyiGeSb6c91Lb09/NkxXY7Qo02Z08Ih2yRKLWnObnTaLG+u9LSKVNF5Af4Ii8cLR9ACOqA4yrMboNCFYmbckaiUsxKjA+CLeI=;24:kwFFXlMRbqeBZ6Ls/oI6klubU5Qcm5TWmJquNtsKiLboOxs09XmwN6/cHhPLtcdagzI/WpRHgt+A+f/dDt4ZFFgj5EBjHNt92rVnZrVpVdc=;7:8xG4ptI69KVZE1J3hYn4kk15Y+x4ZqjCrhTyx+d1OJc+/eaJVKae4+/YwVnuKRYD2RdsR7AXDxO19lsq5XDB5aS1NCJeQBclm+EvHNV22hz0IE5nRhNBew48W19EkNt7L5v6bOSytkGgbEe/5vg7rt2MI7jWfRj2c4HDdVWQM8603580QvsUFefNaSVWV/3peHg7aFTXT9UATH7BHwnalZNeDb/68kznE1vnZGmKLwoWccLBGXFbStyiQMoTBDQz x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 1da74dc9-b795-4d97-a858-08d5422a9fb3 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4603075)(4627115)(201702281549075)(5600026)(4604075)(2017052603307);SRVR:BM1PR0101MB1442; x-ms-traffictypediagnostic: BM1PR0101MB1442: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(3231022)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(2016111802025)(20161123562025)(20161123564025)(6072148)(6043046)(201708071742011);SRVR:BM1PR0101MB1442;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:BM1PR0101MB1442; x-forefront-prvs: 052017CAF1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(366004)(39830400002)(376002)(24454002)(189003)(43544003)(199004)(6916009)(9686003)(39060400002)(2950100002)(6116002)(7696005)(229853002)(74316002)(6436002)(25786009)(5660300001)(33656002)(6506007)(66066001)(478600001)(316002)(93886005)(54906003)(102836003)(3846002)(53936002)(6246003)(55016002)(5250100002)(106356001)(76176011)(3280700002)(68736007)(8936002)(4326008)(81156014)(3660700001)(2906002)(2900100001)(99286004)(105586002)(305945005)(81166006)(8676002)(59450400001)(97736004)(86362001)(53546011)(14454004)(7736002);DIR:OUT;SFP:1102;SCL:1;SRVR:BM1PR0101MB1442;H:BM1PR0101MB1444.INDPRD01.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 X-OriginatorOrg: softnautics.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1da74dc9-b795-4d97-a858-08d5422a9fb3 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2017 13:08:37.7422 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 17b76cff-50c6-4f7a-9198-dd4afc5f8bea X-MS-Exchange-Transport-CrossTenantHeadersStamped: BM1PR0101MB1442 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vBDD8pAq021718 Content-Length: 1327 Lines: 39 Hi Philippe, ________________________________________ > From: Philippe Ombredanne > Sent: Wednesday, December 13, 2017 6:27 PM > To: Dhaval Shah > Cc: pali.rohar@gmail.com; Darren Hart; Andy Shevchenko; platform-driver-x86@vger.kernel.org; LKML > Subject: Re: [PATCH] platform/x86: dell-rbtn: Block comments use * on subsequent lines > > Dhaval, > > On Wed, Dec 13, 2017 at 11:47 AM, Dhaval Shah > wrote: > > > > > And for a short comment block like this, Linus preference is to avoid > > > mixing comment style and go all the way C++ style as in: > > > > > > > // SPDX-License-Identifier: GPL-2.0 > > > > // Dell Airplane Mode Switch driver > > > > // Copyright (C) 2014-2015 Pali Roh?r > > > > > > > > ... for even less boilerplate ;) > > > > Thanks a lot for the link. > > Do you want to me to update along with SPDX in this patchset with V2 or we will update in the next patchset once this patch merge? > > That's not for me to decide, I am just a lowly licensing elf helper scruffy! I can assume that current patch is accepted or I have to provide you any changes > PS: you might want to avoid sending HTML email on lkml, FWIW. That is done by mistake. sorry for that. I will take care of that. -- Cordially Philippe Ombredanne