Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753088AbdLMNYY (ORCPT ); Wed, 13 Dec 2017 08:24:24 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:34851 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752742AbdLMNYX (ORCPT ); Wed, 13 Dec 2017 08:24:23 -0500 Date: Wed, 13 Dec 2017 16:24:04 +0300 From: Dan Carpenter To: Kari Argillander Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux@wolf-entwicklungen.de, linux-kernel@vger.kernel.org, marcin.s.ciupak@gmail.com Subject: Re: [PATCH] staging: pi433: Fix disordered switch case Message-ID: <20171213132402.egz3dz2il4bgt3ue@mwanda> References: <20171212220211.56630-1-kari.argillander@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171212220211.56630-1-kari.argillander@gmail.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8743 signatures=668646 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=674 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712130190 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 383 Lines: 15 On Wed, Dec 13, 2017 at 12:02:11AM +0200, Kari Argillander wrote: > Case: SHAPING_0_5 is writing DATAMODUL_MODLATION_SHAPE_0_3 value and > vice versa > > Signed-off-by: Kari Argillander > --- > I have checked that defines are correct accounting to the datasheet. Looks good. Fixes: 874bcba65f9a ("staging: pi433: New driver") regards, dan carpenter