Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753180AbdLMNgC (ORCPT ); Wed, 13 Dec 2017 08:36:02 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:60091 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752751AbdLMNf7 (ORCPT ); Wed, 13 Dec 2017 08:35:59 -0500 Date: Wed, 13 Dec 2017 14:35:54 +0100 From: Peter Zijlstra To: Wanpeng Li Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Wanpeng Li Subject: Re: [PATCH v8 4/4] KVM: X86: Add flush_on_enter before guest enter Message-ID: <20171213133554.hy3mocgbpu7rmh3m@hirez.programming.kicks-ass.net> References: <1513128784-5924-1-git-send-email-wanpeng.li@hotmail.com> <1513128784-5924-5-git-send-email-wanpeng.li@hotmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1513128784-5924-5-git-send-email-wanpeng.li@hotmail.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 444 Lines: 12 On Tue, Dec 12, 2017 at 05:33:04PM -0800, Wanpeng Li wrote: > + if (xchg(&vcpu->arch.st.steal.preempted, KVM_VCPU_NOT_PREEMPTED) == > + (KVM_VCPU_SHOULD_FLUSH | KVM_VCPU_PREEMPTED)) { > + /* > + * Do TLB_FLUSH before entering the guest, its passed > + * the stage of request checking > + */ > + kvm_vcpu_flush_tlb(vcpu, false); > + } And not a single word, _anywhere_ on why this doesn't need invalidate_gpa or wtf that actually is.