Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753297AbdLMObk (ORCPT ); Wed, 13 Dec 2017 09:31:40 -0500 Received: from mga04.intel.com ([192.55.52.120]:58241 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752175AbdLMObi (ORCPT ); Wed, 13 Dec 2017 09:31:38 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,397,1508828400"; d="scan'208";a="2458534" Subject: Re: [PATCH v5 10/15] soundwire: Add sysfs for SoundWire DisCo properties To: Vinod Koul , Greg Kroah-Hartman Cc: LKML , ALSA , Mark , Takashi , patches.audio@intel.com, alan@linux.intel.com, Charles Keepax , Sagar Dharia , srinivas.kandagatla@linaro.org, plai@codeaurora.org, Sudheer Papothi References: <1512575231-4154-1-git-send-email-vinod.koul@intel.com> <1512575231-4154-11-git-send-email-vinod.koul@intel.com> <20171213091537.GA6269@kroah.com> <20171213095430.GO18649@localhost> From: Pierre-Louis Bossart Message-ID: Date: Wed, 13 Dec 2017 08:31:35 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171213095430.GO18649@localhost> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 916 Lines: 25 On 12/13/2017 03:54 AM, Vinod Koul wrote: > >>> + * Base file is: >>> + * properties >>> + * |---- interface-revision >>> + * |---- master-count >>> + * |---- link-N >>> + * |---- clock-stop-modes >>> + * |---- max-clock-frequency >>> + * |---- clock-frequencies >>> + * |---- default-frame-rows >>> + * |---- default-frame-cols >>> + * |---- dynamic-frame-shape >>> + * |---- command-error-threshold >>> + */ >> Why nest them so deep? Anyway, that's not really an issue I guess, it's >> your ABI, not mine :) > well it gives us a hierarchical view. We have N links... The property definitions follows the MIPI DisCo spec, there's no real creativity here. That said, Vinod you need to remove the master-count - as discussed on the other patch where this property is read this is not relevant for a master if you don't have a representation of a controller.