Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753323AbdLMOsZ (ORCPT ); Wed, 13 Dec 2017 09:48:25 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:48218 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752175AbdLMOsX (ORCPT ); Wed, 13 Dec 2017 09:48:23 -0500 Date: Wed, 13 Dec 2017 17:47:45 +0300 From: Dan Carpenter To: Valentin Vidic Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Marcin Ciupak , Marcus Wolf , Simon =?iso-8859-1?Q?Sandstr=F6m?= Subject: Re: [PATCH 2/8] staging: pi433: move var declaration to function level Message-ID: <20171213144745.tzb2kaeivxb6sz4n@mwanda> References: <20171213142156.3201-1-Valentin.Vidic@CARNet.hr> <20171213142156.3201-2-Valentin.Vidic@CARNet.hr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213142156.3201-2-Valentin.Vidic@CARNet.hr> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8743 signatures=668646 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=932 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712130210 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1000 Lines: 29 On Wed, Dec 13, 2017 at 03:21:50PM +0100, Valentin Vidic wrote: > Fixes checkpatch warning: > > WARNING: Missing a blank line after declarations > > Signed-off-by: Valentin Vidic > --- > drivers/staging/pi433/pi433_if.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c > index 02887988d2ea..07e5352ae5ad 100644 > --- a/drivers/staging/pi433/pi433_if.c > +++ b/drivers/staging/pi433/pi433_if.c > @@ -565,6 +565,7 @@ pi433_tx_thread(void *data) > bool rx_interrupted = false; > int position, repetitions; > int retval; > + int temp; Generally, "temp" means "temperature" and "tmp" means "temporary". The kernel deals with both. Btw "buff" means an 80s dude in a sleeveless shirt and "buf" means a buffer, but the kernel doesn't deal with 80's dudes so that one is less confusing. But the name "tmp" still isn't really ideal here. regards, dan carpenter