Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753274AbdLMOt7 (ORCPT ); Wed, 13 Dec 2017 09:49:59 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:51522 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752807AbdLMOt6 (ORCPT ); Wed, 13 Dec 2017 09:49:58 -0500 Date: Wed, 13 Dec 2017 17:49:28 +0300 From: Dan Carpenter To: Valentin Vidic Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Marcin Ciupak , Marcus Wolf , Simon =?iso-8859-1?Q?Sandstr=F6m?= Subject: Re: [PATCH 4/8] staging: pi433: add parentheses to mask and shift Message-ID: <20171213144928.ilkrb24i3ba4wgwo@mwanda> References: <20171213142156.3201-1-Valentin.Vidic@CARNet.hr> <20171213142156.3201-4-Valentin.Vidic@CARNet.hr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213142156.3201-4-Valentin.Vidic@CARNet.hr> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8743 signatures=668646 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=658 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712130210 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 363 Lines: 12 On Wed, Dec 13, 2017 at 03:21:52PM +0100, Valentin Vidic wrote: > Fixes checkpatch warning: > > WARNING: Possible precedence defect with mask then right shift - may need parentheses > > Signed-off-by: Valentin Vidic Please do your work against linux-next or staging-next. There have been a ton of changes. regards, dan carpenter