Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753247AbdLMOxD (ORCPT ); Wed, 13 Dec 2017 09:53:03 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:52948 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752714AbdLMOw6 (ORCPT ); Wed, 13 Dec 2017 09:52:58 -0500 Date: Wed, 13 Dec 2017 17:52:36 +0300 From: Dan Carpenter To: Valentin Vidic Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Marcin Ciupak , Marcus Wolf , Simon =?iso-8859-1?Q?Sandstr=F6m?= Subject: Re: [PATCH 8/8] staging: pi433: replace printk calls with dev_dbg Message-ID: <20171213145236.blho35l37cwwbxoa@mwanda> References: <20171213142156.3201-1-Valentin.Vidic@CARNet.hr> <20171213142156.3201-8-Valentin.Vidic@CARNet.hr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213142156.3201-8-Valentin.Vidic@CARNet.hr> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8743 signatures=668646 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=2 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=550 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712130211 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 768 Lines: 21 On Wed, Dec 13, 2017 at 03:21:56PM +0100, Valentin Vidic wrote: > drivers/staging/pi433/pi433_if.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c > index 9e558154a143..02a5ba019801 100644 > --- a/drivers/staging/pi433/pi433_if.c > +++ b/drivers/staging/pi433/pi433_if.c > @@ -720,7 +720,7 @@ pi433_tx_thread(void *data) > retval = wait_event_interruptible(device->fifo_wait_queue, > device->free_in_fifo > 0); > if (retval) { > - printk("ABORT\n"); > + dev_dbg(device->dev, "ABORT\n"); > goto abort; Hm... The kernel.org version of this driver has never looked like this. I wonder what you are working against... regards, dan carpenter