Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753234AbdLMPG5 (ORCPT ); Wed, 13 Dec 2017 10:06:57 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:55108 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753050AbdLMPGv (ORCPT ); Wed, 13 Dec 2017 10:06:51 -0500 Date: Wed, 13 Dec 2017 17:36:37 +0300 From: Dan Carpenter To: Valentin Vidic Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Marcin Ciupak , Marcus Wolf , Simon =?iso-8859-1?Q?Sandstr=F6m?= Subject: Re: [PATCH 5/8] staging: pi433: fix DATAMODUL_MODULATION_TYPE_OOK value Message-ID: <20171213143637.wl3z4twqaiwo2qdv@mwanda> References: <20171213142156.3201-1-Valentin.Vidic@CARNet.hr> <20171213142156.3201-5-Valentin.Vidic@CARNet.hr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213142156.3201-5-Valentin.Vidic@CARNet.hr> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8743 signatures=668646 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=678 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712130214 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 941 Lines: 29 On Wed, Dec 13, 2017 at 03:21:53PM +0100, Valentin Vidic wrote: > Reading from the spec, allowed values for modulation scheme > after the shift are: > > 00 FSK > 01 OOK > 10 - 11 reserved > > Signed-off-by: Valentin Vidic > --- > drivers/staging/pi433/rf69_registers.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/pi433/rf69_registers.h b/drivers/staging/pi433/rf69_registers.h > index 33fd91518bb0..981b57d7cc0b 100644 > --- a/drivers/staging/pi433/rf69_registers.h > +++ b/drivers/staging/pi433/rf69_registers.h > @@ -130,7 +130,7 @@ > #define DATAMODUL_MODE_CONTINUOUS_NOSYNC 0x60 > > #define DATAMODUL_MODULATION_TYPE_FSK 0x00 /* default */ > -#define DATAMODUL_MODULATION_TYPE_OOK 0x08 > +#define DATAMODUL_MODULATION_TYPE_OOK 0x01 Look how DATAMODUL_MODULATION_TYPE_OOK is used (in linux-next). We removed the shift. regards, dan carpenter