Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753478AbdLMPXW (ORCPT ); Wed, 13 Dec 2017 10:23:22 -0500 Received: from mail.CARNet.hr ([161.53.123.6]:47061 "EHLO mail.carnet.hr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752340AbdLMPXT (ORCPT ); Wed, 13 Dec 2017 10:23:19 -0500 Date: Wed, 13 Dec 2017 16:23:14 +0100 From: Valentin Vidic To: Dan Carpenter Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Marcin Ciupak , Marcus Wolf , Simon =?iso-8859-1?Q?Sandstr=F6m?= Message-ID: <20171213152314.GC3255@gavran.carpriv.carnet.hr> References: <20171213142156.3201-1-Valentin.Vidic@CARNet.hr> <20171213142156.3201-8-Valentin.Vidic@CARNet.hr> <20171213145236.blho35l37cwwbxoa@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213145236.blho35l37cwwbxoa@mwanda> User-Agent: Mutt/1.9.1 (2017-09-22) X-SA-Exim-Connect-IP: 161.53.12.131 Subject: Re: [PATCH 8/8] staging: pi433: replace printk calls with dev_dbg X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 987 Lines: 27 On Wed, Dec 13, 2017 at 05:52:36PM +0300, Dan Carpenter wrote: > On Wed, Dec 13, 2017 at 03:21:56PM +0100, Valentin Vidic wrote: > > drivers/staging/pi433/pi433_if.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c > > index 9e558154a143..02a5ba019801 100644 > > --- a/drivers/staging/pi433/pi433_if.c > > +++ b/drivers/staging/pi433/pi433_if.c > > @@ -720,7 +720,7 @@ pi433_tx_thread(void *data) > > retval = wait_event_interruptible(device->fifo_wait_queue, > > device->free_in_fifo > 0); > > if (retval) { > > - printk("ABORT\n"); > > + dev_dbg(device->dev, "ABORT\n"); > > goto abort; > > Hm... The kernel.org version of this driver has never looked like this. > I wonder what you are working against... Patch was against staging-testing, in linux-next this printk looks like this: if (retval) { printk("ABORT\n"); goto abort; } -- Valentin