Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753591AbdLMRdG (ORCPT <rfc822;w@1wt.eu>);
        Wed, 13 Dec 2017 12:33:06 -0500
Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:39354 "EHLO
        mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1753154AbdLMRdC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 13 Dec 2017 12:33:02 -0500
Subject: Re: [PATCH 11/45] drivers: misc: remove duplicate includes
To: Pravin Shedge <pravin.shedge4linux@gmail.com>
Cc: haver@linux.vnet.ibm.com, linux-kernel@vger.kernel.org
References: <1512579279-5330-1-git-send-email-pravin.shedge4linux@gmail.com>
From: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>
Date: Wed, 13 Dec 2017 15:32:56 -0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <1512579279-5330-1-git-send-email-pravin.shedge4linux@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-TM-AS-GCONF: 00
x-cbid: 17121317-0056-0000-0000-000003F7C2F1
X-IBM-SpamModules-Scores: 
X-IBM-SpamModules-Versions: BY=3.00008200; HX=3.00000241; KW=3.00000007;
 PH=3.00000004; SC=3.00000244; SDB=6.00959703; UDB=6.00485383; IPR=6.00739724;
 BA=6.00005740; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000;
 ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00018523; XFM=3.00000015;
 UTC=2017-12-13 17:32:59
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
x-cbparentid: 17121317-0057-0000-0000-0000082F0355
Message-Id: <9e80faf1-fc24-4e09-84a7-fe6765f490fa@linux.vnet.ibm.com>
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-13_09:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0
 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000
 definitions=main-1712130246
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1857
Lines: 58

On 12/06/2017 02:54 PM, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
> 
> Signed-off-by: Pravin Shedge <pravin.shedge4linux@gmail.com>

Thanks for the clean-up!

Acked-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>


> ---
>  drivers/misc/genwqe/card_base.c  | 1 -
>  drivers/misc/genwqe/card_ddcb.c  | 1 -
>  drivers/misc/genwqe/card_utils.c | 2 --
>  3 files changed, 4 deletions(-)
> 
> diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c
> index 4fd21e8..42bad26 100644
> --- a/drivers/misc/genwqe/card_base.c
> +++ b/drivers/misc/genwqe/card_base.c
> @@ -34,7 +34,6 @@
>  #include <linux/wait.h>
>  #include <linux/delay.h>
>  #include <linux/dma-mapping.h>
> -#include <linux/module.h>
>  #include <linux/notifier.h>
>  #include <linux/device.h>
>  #include <linux/log2.h>
> diff --git a/drivers/misc/genwqe/card_ddcb.c b/drivers/misc/genwqe/card_ddcb.c
> index ddfeefe..332a0d1 100644
> --- a/drivers/misc/genwqe/card_ddcb.c
> +++ b/drivers/misc/genwqe/card_ddcb.c
> @@ -34,7 +34,6 @@
>  #include <linux/string.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/delay.h>
> -#include <linux/module.h>
>  #include <linux/interrupt.h>
>  #include <linux/crc-itu-t.h>
> 
> diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c
> index 5c0d917..8fec04d 100644
> --- a/drivers/misc/genwqe/card_utils.c
> +++ b/drivers/misc/genwqe/card_utils.c
> @@ -32,11 +32,9 @@
>  #include <linux/iommu.h>
>  #include <linux/delay.h>
>  #include <linux/pci.h>
> -#include <linux/dma-mapping.h>
>  #include <linux/ctype.h>
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
> -#include <linux/delay.h>
>  #include <asm/pgtable.h>
> 
>  #include "genwqe_driver.h"
>