Reply-To: shuah@kernel.org
Subject: Re: [PATCH] usbip: fix usbip bind writing random string after command
 in match_busid
To: Juan Zea <juan.zea@qindel.com>, linux-usb@vger.kernel.org
Cc: Valentina Manea <valentina.manea.m@gmail.com>,
        linux-kernel@vger.kernel.org, Shuah Khan <shuahkh@osg.samsung.com>,
        Shuah Khan <shuah@kernel.org>
References: <204103862.1370220.1513160163538.JavaMail.zimbra@qindel.com>
 <473236275.1374013.1513163260837.JavaMail.zimbra@qindel.com>
From: Shuah Khan <shuah@kernel.org>
Message-ID: <7eb8f072-c4fe-92c9-a7ad-dda390b5f9db@kernel.org>
Date: Wed, 13 Dec 2017 10:42:44 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <473236275.1374013.1513163260837.JavaMail.zimbra@qindel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1100
Lines: 30

On 12/13/2017 04:07 AM, Juan Zea wrote:
> usbip bind writes commands followed by random string when writing to
> match_busid attribute in sysfs, caused by using full variable size
> instead of string length.
> 
> Signed-off-by: Juan Zea <juan.zea@qindel.com>
> ---
>  tools/usb/usbip/src/utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/usb/usbip/src/utils.c b/tools/usb/usbip/src/utils.c
> index 2b3d6d2..ea1a1af 100644
> --- a/tools/usb/usbip/src/utils.c
> +++ b/tools/usb/usbip/src/utils.c
> @@ -42,7 +42,7 @@ int modify_match_busid(char *busid, int add)
>                 snprintf(command, SYSFS_BUS_ID_SIZE + 4, "del %s", busid);
>  
>         rc = write_sysfs_attribute(match_busid_attr_path, command,
> -                                  sizeof(command));
> +                                  strlen(command));
>         if (rc < 0) {
>                 dbg("failed to write match_busid: %s", strerror(errno));
>                 return -1;
> 

Why not use the return value from snprintf() for length, instead of calling
strlen(command)?

thanks,
-- Shuah