Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753759AbdLMRwt (ORCPT <rfc822;w@1wt.eu>);
        Wed, 13 Dec 2017 12:52:49 -0500
Received: from mail-pf0-f181.google.com ([209.85.192.181]:40055 "EHLO
        mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753684AbdLMRwr (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 13 Dec 2017 12:52:47 -0500
X-Google-Smtp-Source: ACJfBotQV18m9k42Wb63PGpsBGNINSUEUN034YAESnW/N2Evlsr+u2DQtK7XTmSlxo/JXXuKKrKiGg==
Message-ID: <1513187564.25033.65.camel@gmail.com>
Subject: Re: [PATCH] ipv6: ip6mr: Recalc UDP checksum before forwarding
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Brendan McGrath <redmcg@redmandi.dyndns.org>,
        "David S . Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Wed, 13 Dec 2017 09:52:44 -0800
In-Reply-To: <1513164048-21368-1-git-send-email-redmcg@redmandi.dyndns.org>
References: <1513164048-21368-1-git-send-email-redmcg@redmandi.dyndns.org>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.6-1+deb9u1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 479
Lines: 12

On Wed, 2017-12-13 at 22:20 +1100, Brendan McGrath wrote:
> Currently, when forwarding from a Virtual Interface to a Physical
> Interface, ip_summed is set to a value of CHECKSUM_UNNECESSARY and
> the UDP checksum has not been calculated.
> 

This seems a bug then ?
CHECKSUM_UNNECESSARY means checksum has been validated.
Not that we want it being computed later in the stack.

If we force a checksum here, what guarantee do we have packet was not
corrupted before we do this ?