Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753611AbdLMSnw (ORCPT ); Wed, 13 Dec 2017 13:43:52 -0500 Received: from mail-ua0-f172.google.com ([209.85.217.172]:38427 "EHLO mail-ua0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753051AbdLMSnr (ORCPT ); Wed, 13 Dec 2017 13:43:47 -0500 X-Google-Smtp-Source: ACJfBov/rNaR70dyhSaHD0banS5k2+kgxiilwUyvvRIECjtb1oBPB7TbwVsoZANVLraCmguRaV4ZODoTGq+kVTHzE+4= MIME-Version: 1.0 In-Reply-To: References: <1507170993-10458-1-git-send-email-ulfalizer@gmail.com> From: Ulf Magnusson Date: Wed, 13 Dec 2017 19:43:46 +0100 Message-ID: Subject: Re: [PATCH] kconfig: Remove menu_end_entry() To: Masahiro Yamada Cc: "Yann E. MORIN" , Linux Kbuild mailing list , Michal Marek , Arnaud Lacombe , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1775 Lines: 49 On Wed, Dec 13, 2017 at 5:32 PM, Ulf Magnusson wrote: > On Sat, Dec 9, 2017 at 5:27 PM, Masahiro Yamada > wrote: >> 2017-10-05 11:36 GMT+09:00 Ulf Magnusson : >>> menu_end_entry() is empty and completely unused as far as I can tell: >>> >>> $ git log -G menu_end_entry --oneline >>> a02f057 [PATCH] kconfig: improve error handling in the parser >>> 1da177e Linux-2.6.12-rc2 >>> >>> Last one is the initial Git commit, where menu_end_entry() is empty as >>> well. I couldn't find anything that redefined it on Google either. >>> >>> It might be a debugging helper for setting a breakpoint after each >>> config, menuconfig, and comment is parsed. IMO it hurts more than it >>> helps in that case by making the parsing code look more complicated at a >>> glance than it really is, and I suspect it doesn't get used much. >>> >>> Tested by running the Kconfiglib test suite, which indirectly verifies >>> that the .config files generated by the C implementation for each >>> defconfig file in the kernel stays the same. >>> >>> Signed-off-by: Ulf Magnusson >>> --- >> >> Removing menu_end_entry() should be OK, >> but it is tedious to sync *.y and *_shipped. >> >> I'd like to apply v2 (https://patchwork.kernel.org/patch/9992029/) >> on top of my patch (https://patchwork.kernel.org/patch/10103743/) >> >> >> -- >> Best Regards >> Masahiro Yamada > > Fine by me, if people have no objections to adding Flex and Bison as build-time > requirements. Looks like you already went over it in > https://lkml.org/lkml/2017/8/19/49. > > Cheers, > Ulf Thanks for stepping in and merging those earlier Kconfig patches by the way! Only noticed just now. Cheers, Ulf