Message-ID: <1513191696.27409.33.camel@perches.com>
Subject: Re: [PATCH 2/8] staging: pi433: move var declaration to function
 level
From: Joe Perches <joe@perches.com>
To: Valentin Vidic <Valentin.Vidic@CARNet.hr>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Simon =?ISO-8859-1?Q?Sandstr=F6m?= <simon@nikanor.nu>,
        Marcin Ciupak <marcin.s.ciupak@gmail.com>,
        Marcus Wolf <linux@wolf-entwicklungen.de>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Date: Wed, 13 Dec 2017 11:01:36 -0800
In-Reply-To: <20171213142156.3201-2-Valentin.Vidic@CARNet.hr>
References: <20171213142156.3201-1-Valentin.Vidic@CARNet.hr>
         <20171213142156.3201-2-Valentin.Vidic@CARNet.hr>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 850
Lines: 23

On Wed, 2017-12-13 at 15:21 +0100, Valentin Vidic wrote:
>   WARNING: Missing a blank line after declarations
[]
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
[]
> @@ -565,6 +565,7 @@ pi433_tx_thread(void *data)
>  	bool   rx_interrupted = false;
>  	int    position, repetitions;
>  	int    retval;
> +	int    temp;
>  
>  	while (1) {
>  		/* wait for fifo to be populated or for request to terminate*/
> @@ -700,7 +701,7 @@ pi433_tx_thread(void *data)
>  		while ((repetitions > 0) && (size > position)) {
>  			if ((size - position) > device->free_in_fifo) {
>  				/* msg to big for fifo - take a part */
> -				int temp = device->free_in_fifo;
> +				temp = device->free_in_fifo;

It's generally better to keep variable declarations
to the innermost scope possible and not move them
outwards unnecessarily.