Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754049AbdLMUuO (ORCPT ); Wed, 13 Dec 2017 15:50:14 -0500 Received: from fllnx210.ext.ti.com ([198.47.19.17]:17050 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753862AbdLMUuL (ORCPT ); Wed, 13 Dec 2017 15:50:11 -0500 Subject: Re: [PATCH] leds: as3645a: Fix checkpatch warnings To: Jacek Anaszewski , , , , , , CC: , , References: <20171212215011.30066-1-dmurphy@ti.com> <98df06ef-9ee4-02b1-6d6b-f10b911a8d71@gmail.com> From: Dan Murphy Message-ID: <799ae164-701a-87ce-fadf-8278f01c10d6@ti.com> Date: Wed, 13 Dec 2017 14:49:38 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <98df06ef-9ee4-02b1-6d6b-f10b911a8d71@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 872 Lines: 44 Pavel and Laurent On 12/13/2017 02:43 PM, Jacek Anaszewski wrote: > Dan, > > On 12/13/2017 09:41 PM, Dan Murphy wrote: >> Jacek >> >> On 12/13/2017 02:29 PM, Jacek Anaszewski wrote: >>> Hi Dan, >>> >>> checkpatch.pl doesn't want to be mentioned in the patch subject :-) >>> >> >> Ack >> >>> "WARNING: A patch subject line should describe the change not the tool >>> that found it" >>> >>> Preferably I'd see two separate patches. >>> >> >> So you want me to split them up? I have no issue with that. > > Yeah, it will be easier to come up with concise but meaningful > subjects. > When I split these up can I add your Acked-by to each patch or would you prefer to resend your Acked-by for each patch? Dan >>> Also, line length limit for the commit description is 75 characters. >>> Please use whole available space. >>> >> >> > -- ------------------ Dan Murphy