Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753849AbdLMUv1 (ORCPT ); Wed, 13 Dec 2017 15:51:27 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:44870 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753149AbdLMUvZ (ORCPT ); Wed, 13 Dec 2017 15:51:25 -0500 Date: Wed, 13 Dec 2017 15:51:23 -0500 (EST) Message-Id: <20171213.155123.2302738718764109294.davem@davemloft.net> To: ivan.khoronzhuk@linaro.org Cc: grygorii.strashko@ti.com, netdev@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 net-next] net: ethernet: ti: cpdma: correct error handling for chan create From: David Miller In-Reply-To: <1513112795-20045-1-git-send-email-ivan.khoronzhuk@linaro.org> References: <1513112795-20045-1-git-send-email-ivan.khoronzhuk@linaro.org> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 13 Dec 2017 12:51:25 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 470 Lines: 12 From: Ivan Khoronzhuk Date: Tue, 12 Dec 2017 23:06:35 +0200 > It's not correct to return NULL when that is actually an error and > function returns errors in any other wrong case. In the same time, > the cpsw driver and davinci emac doesn't check error case while > creating channel and it can miss actual error. Also remove WARNs > replacing them on dev_err msgs. > > Signed-off-by: Ivan Khoronzhuk Applied.