Date: Wed, 13 Dec 2017 12:56:37 -0800
From: Sinclair Yeh <syeh@vmware.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>,
        Thomas Hellstrom <thellstrom@vmware.com>,
        David Airlie <airlied@linux.ie>,
        Deepak Singh Rawat <drawat@vmware.com>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>,
        Arvind Yadav <arvind.yadav.cs@gmail.com>,
        Ravikant B Sharma <ravikant.s2@samsung.com>,
        Joe Perches <joe@perches.com>, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vmwgfx: use monotonic event timestamps
Message-ID: <20171213205635.GB16788@promb-2n-dhcp36.eng.vmware.com>
References: <20171127111629.1682286-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171127111629.1682286-1-arnd@arndb.de>
User-Agent: Mutt/1.8.2 (2017-04-18)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2017 20:56:45.3959 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b305de19-e94c-4337-d7aa-08d5426c05bd
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR05MB3288
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1913
Lines: 56

This looks okay to me.  Although we should change eaction->tv_* type
to 64-bit as well.

I'll roll this in to our next pull request.

thanks,

Sinclair


On Mon, Nov 27, 2017 at 12:16:19PM +0100, Arnd Bergmann wrote:
> DRM_VMW_EVENT_FENCE_SIGNALED (struct drm_vmw_event_fence) and
> DRM_EVENT_VBLANK (struct drm_event_vblank) pass timestamps in 32-bit
> seconds/microseconds format.
> 
> As of commit c61eef726a78 ("drm: add support for monotonic vblank
> timestamps"), other DRM drivers use monotonic times for drm_event_vblank,
> but vmwgfx still uses CLOCK_REALTIME for both events, which suffers from
> the y2038/y2106 overflow as well as time jumps.
> 
> For consistency, this changes vmwgfx to use ktime_get_ts64 as well,
> which solves those problems and avoids the deprecated do_gettimeofday()
> function.
> 
> This should be transparent to to user space, as long as it doesn't
> compare the time against the result of gettimeofday().
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> index d6b1c509ae01..55214d0da66e 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> @@ -897,11 +897,12 @@ static void vmw_event_fence_action_seq_passed(struct vmw_fence_action *action)
>  	spin_lock_irq(&dev->event_lock);
>  
>  	if (likely(eaction->tv_sec != NULL)) {
> -		struct timeval tv;
> +		struct timespec64 ts;
>  
> -		do_gettimeofday(&tv);
> -		*eaction->tv_sec = tv.tv_sec;
> -		*eaction->tv_usec = tv.tv_usec;
> +		ktime_get_ts64(&ts);
> +		/* monotonic time, so no y2038 overflow */
> +		*eaction->tv_sec = ts.tv_sec;
> +		*eaction->tv_usec = ts.tv_nsec / NSEC_PER_USEC;
>  	}
>  
>  	drm_send_event_locked(dev, eaction->event);
> -- 
> 2.9.0
>