Date: Wed, 13 Dec 2017 13:25:23 -0800
From: Sinclair Yeh <syeh@vmware.com>
To: Woody Suwalski <terraluna977@gmail.com>
Cc: DRI mailing list <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>, Dave Airlie <airlied@linux.ie>
Subject: Re: [PATCH] 4.15 vmgfx boot warning
Message-ID: <20171213212522.GC16788@promb-2n-dhcp36.eng.vmware.com>
References: <c845316e-c0f8-9ef7-2bf5-97418d8094c7@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c845316e-c0f8-9ef7-2bf5-97418d8094c7@gmail.com>
User-Agent: Mutt/1.8.2 (2017-04-18)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2017 21:25:33.3336 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ba38836-7e10-481f-bf46-08d542700bb5
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR05MB3285
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1133
Lines: 39

Hi Woody,

On Wed, Nov 22, 2017 at 04:05:50PM -0500, Woody Suwalski wrote:
> The 4.15 vmwgfx driver shows a warning during boot (32 bit x86)
> It is caused by a mismatch between the result of vmw_enable_vblank() and
> what the drm_atomic_helper expects:
> ?? /...
> ?? ret = drm_crtc_vblank_get(crtc);
> ?? WARN_ONCE(ret != -EINVAL, "driver forgot to call
> drm_crtc_vblank_off()\n");

This doesn't apply to us because we don't have vblank support, and so
-ENOSYS seems to be the right error.

In the commit message for 84014b0a39ee, it does state a check for this
condition, but the check itself is based on dev->irq_enabled.

Is there another way to check for vblank support?


> ?? /...
> 
> Signed-off by: Woody Suwalski <terraluna977@gmail.com>
> 
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c?? ?2017-11-22 15:29:46.511674079
> -0500
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c?? ?2017-11-22 15:30:35.344559592
> -0500
> @@ -1869,7 +1869,7 @@ u32 vmw_get_vblank_counter(struct drm_de
> ? */
> ?int vmw_enable_vblank(struct drm_device *dev, unsigned int pipe)
> ?{
> -?? ?return -ENOSYS;
> +?? ?return -EINVAL;
> ?}
> 
> ?/**
>