Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753995AbdLMVxm (ORCPT ); Wed, 13 Dec 2017 16:53:42 -0500 Received: from mga12.intel.com ([192.55.52.136]:30917 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753813AbdLMVxh (ORCPT ); Wed, 13 Dec 2017 16:53:37 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,398,1508828400"; d="scan'208";a="15774167" From: "Schmauss, Erik" To: "Rafael J. Wysocki" , Vasyl Gomonovych CC: "Moore, Robert" , "Zheng, Lv" , "Wysocki, Rafael J" , "Len Brown" , ACPI Devel Maling List , "devel@acpica.org" , Linux Kernel Mailing List Subject: RE: [PATCH] ACPICA: Fix indentation Thread-Topic: [PATCH] ACPICA: Fix indentation Thread-Index: AQHTcEHGQq6KigsPAUaU2JvCoxqYKKM6M1OAgAelAUA= Date: Wed, 13 Dec 2017 21:53:35 +0000 Message-ID: References: <1512750553-15467-1-git-send-email-gomonovych@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjhmNDZiODQtMmI1ZC00NzUyLWI2ZDQtNjk1NDczMDA1MjcxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InN0NG1hVk1HclwvMERuenBqcU1MZk8wMEhvN1JrMUQ5RWRITCthV2g4TjVNPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vBDLrlH5002458 Content-Length: 1881 Lines: 51 > -----Original Message----- > From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of Rafael > J. Wysocki > Sent: Friday, December 8, 2017 9:06 AM > To: Vasyl Gomonovych > Cc: Moore, Robert ; Zheng, Lv > ; Wysocki, Rafael J ; Len > Brown ; ACPI Devel Maling List ; > devel@acpica.org; Linux Kernel Mailing List ; > Schmauss, Erik > Subject: Re: [PATCH] ACPICA: Fix indentation > > On Fri, Dec 8, 2017 at 5:29 PM, Vasyl Gomonovych > wrote: > > This patch avoids that smatch reports the following: > > drivers/acpi/acpica/exdump.c:623 acpi_ex_dump_operand() warn: > > inconsistent indenting > > > > Signed-off-by: Vasyl Gomonovych > > This is ACPICA code, so changes like this should go in via the upstream. > Hi, > Erik may want to pick this up, however. > Thanks for pointing this out. I found solution to fix the indentation issue. It will be in the next release. Erik > > --- > > drivers/acpi/acpica/exdump.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/acpi/acpica/exdump.c > > b/drivers/acpi/acpica/exdump.c index 83398dc..f43d3d7 100644 > > --- a/drivers/acpi/acpica/exdump.c > > +++ b/drivers/acpi/acpica/exdump.c > > @@ -619,8 +619,8 @@ void acpi_ex_dump_operand(union > > acpi_operand_object *obj_desc, u32 depth) > > > > ACPI_FUNCTION_NAME(ex_dump_operand) > > > > - /* Check if debug output enabled */ > > - if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) { > > + /* Check if debug output enabled */ > > + if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) { > > return; > > } > > > > --