Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752668AbdLMWX0 (ORCPT ); Wed, 13 Dec 2017 17:23:26 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:47364 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751540AbdLMWXX (ORCPT ); Wed, 13 Dec 2017 17:23:23 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3212C605FB Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 13 Dec 2017 14:23:21 -0800 From: Stephen Boyd To: Abhishek Sahu Cc: Michael Turquette , Andy Gross , David Brown , Rajendra Nayak , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/13] Updates for QCOM Alpha PLL Message-ID: <20171213222321.GN7997@codeaurora.org> References: <1506621050-10129-1-git-send-email-absahu@codeaurora.org> <20171207062331.GI4283@codeaurora.org> <0fc3e5cdf9d5778655f302868154aff6@codeaurora.org> <20171209001639.GA7997@codeaurora.org> <7d231505ed928e7e377b854ebff2b40f@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7d231505ed928e7e377b854ebff2b40f@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2235 Lines: 54 On 12/11, Abhishek Sahu wrote: > On 2017-12-09 05:46, Stephen Boyd wrote: > >On 12/08, Abhishek Sahu wrote: > >>On 2017-12-07 11:53, Stephen Boyd wrote: > >>>On 09/28, Abhishek Sahu wrote: > >>>>This patch series does the miscellaneous changes in QCOM Alpha PLL > >>>>operation and structure to support other types of Alpha PLL’s. > >>>> > >>>>1. It adds the pll_type which will be used for determining all > >>>> the properties of Alpha PLL. > >>>>2. It adds the support for Brammo and Huayra PLL’s for which > >>>> the support is not available in existing alpha PLL code. > >>>>3. There won’t be any change in existing users of Alpha PLL’s > >>>> since all the newly added code will be under flag for the default > >>>> PLL operations. > >>>> > >>> > >>>Ok. I took a long look at this today. I rewrote a bunch of stuff. > >> > >> Thanks Stephen for reviewing the changes and making the code > >> cleaner. I checked all the code changes and everything looks > >> good. It will work for all of our requirement. I will check > >> with other PLL users also once and then update the patch > >> series with all your suggested code changes after complete > >> testing. > > > >Ok. Please don't resend. I've pushed out the branch to clk-next, > >and it can be adjusted if needed, or dropped and rewritten if > >something is totally busted. > > Thanks Stephen for your great help and support. > It seems, we are getting the error in the following error with these > patches because of missing EXPORT_SYMBOL_GPL for > clk_alpha_pll_regs and clk_hw_is_enabled. > > > ERROR: "clk_alpha_pll_regs" [drivers/clk/qcom/mmcc-msm8996.ko] > undefined! > > ERROR: "clk_hw_is_enabled" [drivers/clk/qcom/clk-qcom.ko] undefined! > > Caused by commits > > d1506b749e92 ("clk: qcom: support for alpha pll properties") > e66a4d6d0081 ("clk: qcom: support for dynamic updating the PLL") > 301803e6013b ("clk: qcom: support Huayra type Alpha PLL") Yep. I'll export the regs and remove the clk_hw_is_enabled() usage. Should be possible to do that inside the ops directly instead of going through the framework for it. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project