Date: Thu, 14 Dec 2017 10:31:09 +0900
From: Andi Shyti <andi.shyti@samsung.com>
To: Philippe Ombredanne <pombredanne@nexb.com>
Cc: Kukjin Kim <kgene@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>,
        Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org,
        linux-samsung-soc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH v2] spi: s3c64xx: add SPDX identifier
Message-id: <20171214013109.GC11657@gangnam.samsung>
MIME-version: 1.0
Content-type: text/plain; charset="us-ascii"
Content-disposition: inline
In-reply-to: <CAOFm3uHP-4UN+gzXzZc1ptptFm5f9uhafKyE963+DiamzdRTdw@mail.gmail.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20171213080544epcas2p29731b6c65f760ab1b9ac71d530fcaf77@epcas2p2.samsung.com>
        <20171213080530.12724-1-andi.shyti@samsung.com>
        <CAOFm3uHP-4UN+gzXzZc1ptptFm5f9uhafKyE963+DiamzdRTdw@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1483
Lines: 61

Hi Philippe,

> > diff --git a/include/linux/platform_data/spi-s3c64xx.h b/include/linux/platform_data/spi-s3c64xx.h
> > index da79774078a7..8917f38c97c5 100644
> > --- a/include/linux/platform_data/spi-s3c64xx.h
> > +++ b/include/linux/platform_data/spi-s3c64xx.h
> > @@ -2,9 +2,7 @@
> >   * Copyright (C) 2009 Samsung Electronics Ltd.
> >   *     Jaswinder Singh <jassi.brar@samsung.com>
> >   *
> > - * This program is free software; you can redistribute it and/or modify
> > - * it under the terms of the GNU General Public License version 2 as
> > - * published by the Free Software Foundation.
> > + * SPDX-License-Identifier: GPL-2.0
> >   */
> >
> >  #ifndef __SPI_S3C64XX_H
> > --
> > 2.15.1
> >
> 
> 
> You still need to put this line at the very top of the file, first
> line. That's the convention for the SPDX tags as documented by Thomas
> Gleixner.

I had some doubts on this one, indeed. How should it be done in
this case:

1. Strictly by Thomas documentation:

  /* SPDX-License-Identifier: GPL-2.0 */

  /*
   * Copyright (C) 2009 Samsung Electronics Ltd.
   *     Jaswinder Singh <jassi.brar@samsung.com>
   */

or

2. with a little interpretation

  /*
   * SPDX-License-Identifier: GPL-2.0
   *
   * Copyright (C) 2009 Samsung Electronics Ltd.
   *     Jaswinder Singh <jassi.brar@samsung.com>
   */

(I opted for the one with the least number of changes)

Thanks,
Andi

> > + * SPDX-License-Identifier: GPL-2.0
> 
> 
> -- 
> Cordially
> Philippe Ombredanne
>