Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752263AbdLNDH5 (ORCPT ); Wed, 13 Dec 2017 22:07:57 -0500 Received: from mail-oi0-f46.google.com ([209.85.218.46]:43578 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751625AbdLNDHz (ORCPT ); Wed, 13 Dec 2017 22:07:55 -0500 X-Google-Smtp-Source: ACJfBostP7p1VaNGObntHB18PU/dTW8gkYn1U6OP4vDDmKmnJlZ8H3VwYGY8vQKj2SBkNvDljZJPA9rbb3IE/8HbTvg= MIME-Version: 1.0 In-Reply-To: <20171213122329.GU8318@piout.net> References: <64a38f4a15a2f8dae4a9fd0a3fc2a312e86c733d.1510749847.git.baolin.wang@linaro.org> <20171212221643.GL8318@piout.net> <20171213110426.GQ8318@piout.net> <20171213121603.GF6416@sirena.org.uk> <20171213122329.GU8318@piout.net> From: Baolin Wang Date: Thu, 14 Dec 2017 11:07:54 +0800 Message-ID: Subject: Re: [PATCH v2] rtc: Add tracepoints for RTC system To: Alexandre Belloni Cc: Mark Brown , Arnd Bergmann , Alessandro Zummo , Steven Rostedt , Ingo Molnar , linux-rtc@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1010 Lines: 23 On 13 December 2017 at 20:23, Alexandre Belloni wrote: > On 13/12/2017 at 12:16:03 +0000, Mark Brown wrote: >> On Wed, Dec 13, 2017 at 12:04:26PM +0100, Alexandre Belloni wrote: >> >> > Also, I think we could try having only the time64_t in the ring buffer. >> > Maybe I'm wrong but I think tools reading that buffer can do the >> > conversion themselves. Maybe I don't understand correctly how >> > tracepoints work and this doesn't make sense, tell me. >> >> Tools reading the buffer can do the conversion themselves but it's also >> useful for users to just view the log directly via tracing/trace >> sometimes. OTOH the whole point is to be low overhead so... > > Yes, that is why I suggest keeping both representation in the printk > but only time64_t in the buffer. And this would be more convenient if we > add a way to pretty print a time64_t in vsprintf. OK. I will only keep time64_t in the buffer. Thanks for all your comments. -- Baolin.wang Best Regards