Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751072AbdLNGRB (ORCPT ); Thu, 14 Dec 2017 01:17:01 -0500 Received: from mail-wr0-f173.google.com ([209.85.128.173]:45033 "EHLO mail-wr0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751035AbdLNGQ7 (ORCPT ); Thu, 14 Dec 2017 01:16:59 -0500 X-Google-Smtp-Source: ACJfBov0Y8hK4xnavZ2Tdkb6HUwDyhCV2UOGHBFi1NmO8mOuB7kBTYyTH+SCaG30v7Ju/qxHC13PeQ3SjC1WVB/y2L8= MIME-Version: 1.0 In-Reply-To: <20171214013109.GC11657@gangnam.samsung> References: <20171213080530.12724-1-andi.shyti@samsung.com> <20171214013109.GC11657@gangnam.samsung> From: Philippe Ombredanne Date: Thu, 14 Dec 2017 07:16:17 +0100 Message-ID: Subject: Re: [PATCH v2] spi: s3c64xx: add SPDX identifier To: Andi Shyti Cc: Kukjin Kim , Krzysztof Kozlowski , Mark Brown , linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, LKML , Andi Shyti Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1735 Lines: 61 Andi, On Thu, Dec 14, 2017 at 2:31 AM, Andi Shyti wrote: > Hi Philippe, > >> > diff --git a/include/linux/platform_data/spi-s3c64xx.h b/include/linux/platform_data/spi-s3c64xx.h >> > index da79774078a7..8917f38c97c5 100644 >> > --- a/include/linux/platform_data/spi-s3c64xx.h >> > +++ b/include/linux/platform_data/spi-s3c64xx.h >> > @@ -2,9 +2,7 @@ >> > * Copyright (C) 2009 Samsung Electronics Ltd. >> > * Jaswinder Singh >> > * >> > - * This program is free software; you can redistribute it and/or modify >> > - * it under the terms of the GNU General Public License version 2 as >> > - * published by the Free Software Foundation. >> > + * SPDX-License-Identifier: GPL-2.0 >> > */ >> > >> > #ifndef __SPI_S3C64XX_H >> > -- >> > 2.15.1 >> > >> >> >> You still need to put this line at the very top of the file, first >> line. That's the convention for the SPDX tags as documented by Thomas >> Gleixner. > > I had some doubts on this one, indeed. How should it be done in > this case: > > 1. Strictly by Thomas documentation: > > /* SPDX-License-Identifier: GPL-2.0 */ > > /* > * Copyright (C) 2009 Samsung Electronics Ltd. > * Jaswinder Singh > */ > > or > > 2. with a little interpretation > > /* > * SPDX-License-Identifier: GPL-2.0 > * > * Copyright (C) 2009 Samsung Electronics Ltd. > * Jaswinder Singh > */ > > (I opted for the one with the least number of changes) You should go strictly by Thomas' doc. This is one area where consistency is the thing that brings benefits. Interpretation is not needed. So please, consider going with 1. -- Cordially Philippe Ombredanne