Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751357AbdLNGVZ (ORCPT ); Thu, 14 Dec 2017 01:21:25 -0500 Received: from mail-ot0-f194.google.com ([74.125.82.194]:36525 "EHLO mail-ot0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751092AbdLNGVX (ORCPT ); Thu, 14 Dec 2017 01:21:23 -0500 X-Google-Smtp-Source: ACJfBosU/z3NCZniT57OWm0sCuV/HWzkXeozWQL60vPe5IIv75ZaToYXD1mz82BXGzSG630eVtjmAQ== Date: Thu, 14 Dec 2017 11:51:17 +0530 From: Aishwarya Pant To: Greg Kroah-Hartman Cc: Thomas Petazzoni , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH] staging: fbtft: replace __ATTR() with DEVICE_ATTR() Message-ID: <20171214062117.GA8758@mordor.localdomain> References: <20171211095430.GA2158@mordor.localdomain> <20171213115000.GA3963@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213115000.GA3963@kroah.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1830 Lines: 67 On Wed, Dec 13, 2017 at 12:50:00PM +0100, Greg Kroah-Hartman wrote: > On Mon, Dec 11, 2017 at 03:24:30PM +0530, Aishwarya Pant wrote: > > This is a clean-up patch which replaces the uses of raw __ATTR(...) > > macro with the more conventional DEVICE_ATTR(...) for defining device > > attributes. > > > > Done using coccinelle- > > > > @r@ > > identifier foo, n; > > @@ > > > > struct device_attribute foo = __ATTR(n, ...); > > > > @script:python p@ > > id; > > foo << r.foo; > > n << r.n; > > @@ > > > > // standardise the variable name to dev_attr_{name} > > coccinelle.id = "dev_attr_" + n > > > > @@ > > identifier r.foo; > > declarer name DEVICE_ATTR; > > @@ > > > > //change definition > > - struct device_attribute foo = __ATTR > > + DEVICE_ATTR > > (...); > > > > @depends on r@ > > identifier r.foo, p.id; > > @@ > > > > // replace usages everywhere > > - foo > > + id > > > > Signed-off-by: Aishwarya Pant > > --- > > drivers/staging/fbtft/fbtft-sysfs.c | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c > > index 712096659aa0..506d604d01bb 100644 > > --- a/drivers/staging/fbtft/fbtft-sysfs.c > > +++ b/drivers/staging/fbtft/fbtft-sysfs.c > > @@ -197,19 +197,18 @@ static ssize_t show_debug(struct device *device, > > return snprintf(buf, PAGE_SIZE, "%lu\n", par->debug); > > } > > > > -static struct device_attribute debug_device_attr = > > - __ATTR(debug, 0660, show_debug, store_debug); > > +static DEVICE_ATTR(debug, 0660, show_debug, store_debug); > > This should be DEVICE_ATTR_RW(), right? 0660 makes no sense... If it doesn't make sense here, I can replace it with DEVICE_ATTR_RW. Though, 0660 has more open permissions than 0644. > > thanks, > > greg k-h