Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751300AbdLNIMX (ORCPT ); Thu, 14 Dec 2017 03:12:23 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:53391 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785AbdLNIMW (ORCPT ); Thu, 14 Dec 2017 03:12:22 -0500 Date: Thu, 14 Dec 2017 09:12:11 +0100 From: Maxime Ripard To: Chen-Yu Tsai Cc: Liam Girdwood , Mark Brown , alsa-devel@alsa-project.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Code Kipper Subject: Re: [PATCH] ASoC: sun4i-i2s: Show detailed error when DAI configuration callbacks fail Message-ID: <20171214081211.ow6q5cgwew2buwfj@flea.lan> References: <20171214072928.6613-1-wens@csie.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="f656jwpyda5fjvbp" Content-Disposition: inline In-Reply-To: <20171214072928.6613-1-wens@csie.org> User-Agent: NeoMutt/20171027 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1999 Lines: 52 --f656jwpyda5fjvbp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 14, 2017 at 03:29:28PM +0800, Chen-Yu Tsai wrote: > When any of the DAI hardware configuration callbacks (.hw_param, > .set_fmt, .set_sysclk) fails, there is no explanation about why it > failed. This is particularly confusing for .hw_param, which covers > many parameters of the DAI. Telling the users what parameter isn't > supported, and what the requested value was goes a long way for > developers trying to combine sun4i-i2s with external codecs. >=20 > This patch adds dev_err calls explaining what isn't supported or > failed, and what the value was. sun4i_i2s_set_clk_rate()'s first > parameter was changed to a struct snd_soc_dai *dai, so we can > get the underlying device. >=20 > Signed-off-by: Chen-Yu Tsai Acked-by: Maxime Ripard Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --f656jwpyda5fjvbp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAloyMkkACgkQ0rTAlCFN r3RrFBAAkBqFg1H2qDibgk9GE/02EJRx9FjdalyWHSiHpgaZEiFHeigae0/MfC/8 dmckjIsS/mynXvKi65iBPMMT74HNMqHdeEXr4e8GHqGVbBAL04Q5d/kujo1WRdHI WiJEAYKNfwTuGz6NWAF3iYig1aFYeqeZpNWLum8L8VhdpFLn+MQv3D9mxxJBGiK7 w6QFRZ0MmZ+nDL+dkfMeaLsYozxQWbUPJazBzD0NgqzbTHDucHYN7ts+a9OsBBgk yene2xitzYOfylzo1g+eqU7ZF6LJagEpSvgeNaY7osjXjEqRvlXImg8dihyh6pAm qZAj7qt0pAym0MvZhHrCOtePGH+XEqSF7ezWGtWJVTJW6jdpuU3h9Qft782w4S2l FxhO2eK1m35Zho93GX7CXBSgu5TS0ysZel6FBPCde2zi9ykZrTkzSgGIu7quvhaN GZzj0uWaolwDjouyBZzH1Sky48wlTV6GL+CfHf8IJHVbGu72vqaZDaRkJrNVpY5v xgiJL2cRgsl/jZgTEHgdU1DrzIg2McmBuK3u3PrZf29XqeXL8Svkr3G2XNwcWtYo 3q8yXxDhmazjOT1IOOQae9lgft0G5cFUQTvBhs4oBK5Rzz38tNk6bW+tDDUrh0uS SIoeWMUn4+AN9EMxwguBCwU3OlNfMeUCj+CLbXcx7jgsNTny6VQ= =v65W -----END PGP SIGNATURE----- --f656jwpyda5fjvbp--