Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751091AbdLNJMN (ORCPT ); Thu, 14 Dec 2017 04:12:13 -0500 Received: from mail-bo1ind01on0090.outbound.protection.outlook.com ([104.47.101.90]:38624 "EHLO IND01-BO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750737AbdLNJML (ORCPT ); Thu, 14 Dec 2017 04:12:11 -0500 From: Dhaval Shah To: Joe Perches , Philippe Ombredanne CC: "pali.rohar@gmail.com" , Darren Hart , Andy Shevchenko , "platform-driver-x86@vger.kernel.org" , LKML Subject: Re: [PATCH] platform/x86: dell-rbtn: Block comments use * on subsequent lines Thread-Topic: [PATCH] platform/x86: dell-rbtn: Block comments use * on subsequent lines Thread-Index: AQHTc+ueO0Cna25wN0e/W2phGgOFfqNBAKSAgAAFUfSAAATwgIAAC56BgAAcd4CAAALy2YAAM2AAgAEll/w= Date: Thu, 14 Dec 2017 09:12:06 +0000 Message-ID: References: <20171213082301.23209-1-dhaval.shah@softnautics.com> , ,<1513167907.27409.3.camel@perches.com> ,<1513179572.27409.8.camel@perches.com> In-Reply-To: <1513179572.27409.8.camel@perches.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [219.65.63.222] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BM1PR0101MB1444;6:Ozt26UKUlCVhnFG7RGKFPh6Uhl6VKkkltjrbhQCr16Ionls64LNYDQxnXy5iC1LPqC9KCLuVxuaXbcrryg+4zjcsVsSjDkIHgntvINan+0VIJ4i8mzuR5LZIX5CNuImMCFUFpkD74875BK4wN6gxNo0nZYmbulbHHNdLg7FxB4RlYkZzMR5n3jtFSkuo0v5QxlRf7p8m72hpyNAwb6fFc0SWVwHkcnWdx6/2Jpc3esQRfvxVKc764NDLpq8AUaZPfXvXAhXYKkdSuZcXoc+m+UEI+ZC+ptd9j/2YcSRoq9z7LmG07UWXKORd5wGxiX1Dn/A75U4WSEE3BFFaYVo5RBk2bbBbItvogiIiZIp1lDU=;5:eIzpU1TDpitKm33MtXg2wnTTjShtJH+6Pb6hZ2U3CVkYoChHmR/SyoPZAKyHE1//oXfHHJ6EmETDSWdsGAEGLWS1U4PxUuiCqfLEOKZ5YSzn+TOF/9k8Ec3YhJizDfAGtxI2TtqAiwN+hkrTkvRXY2z97qLll9v8QYX7ubQPk/c=;24:MJZmPJiiZuy1s8TA6ToD6pkQIC+Y54gLbsCJLooNGA/9injip+G34jSac3bdEwMvNcku01hMWZti74wwf1R4VGpaADQ7cUl+sUdjX7lx+Rk=;7:9EJBXi7/eTUWZuGO3b1bFee84FhVtaGUUDztFvGMjZc+CA0jS5+3qxptG1ZJqGN1SOG7JiaF7x0UrWSXjKbneQjITNW2so7HapCyOeAgKo5vrpNF1hE07yqcRHRMHZ0elDXFzwtIdaMDWZrAPXlzAkptSqEZa3rkS+BrCUY53xbQ6LM8C+y0k0WlVsU4flQ08Zkc7bPO5qDNqY2kA2LIni4RV+3L9vNz1CvYQkIvZZpb/oR/TqWT/TSrVuSSmoGH x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: de79195c-ade4-4936-53aa-08d542d2bf86 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4603075)(4627115)(201702281549075)(5600026)(4604075)(2017052603307);SRVR:BM1PR0101MB1444; x-ms-traffictypediagnostic: BM1PR0101MB1444: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dhaval.shah@softnautics.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(3231022)(3002001)(10201501046)(93006095)(93001095)(6041248)(20161123555025)(20161123562025)(2016111802025)(20161123564025)(201703131423075)(201703061421075)(20161123560025)(20161123558100)(6072148)(6043046)(201708071742011);SRVR:BM1PR0101MB1444;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:BM1PR0101MB1444; x-forefront-prvs: 05214FD68E x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(376002)(346002)(24454002)(189003)(199004)(377424004)(97736004)(39060400002)(4001150100001)(99286004)(102836003)(6246003)(110136005)(3660700001)(93886005)(33656002)(9686003)(68736007)(5250100002)(4326008)(305945005)(229853002)(3280700002)(86362001)(508600001)(2906002)(53546011)(76176011)(105586002)(2900100001)(6436002)(54906003)(6306002)(2950100002)(81166006)(8936002)(74316002)(66066001)(6116002)(14454004)(81156014)(8676002)(3846002)(7696005)(7736002)(53936002)(5660300001)(106356001)(25786009)(55016002)(6506007)(966005);DIR:OUT;SFP:1102;SCL:1;SRVR:BM1PR0101MB1444;H:BM1PR0101MB1444.INDPRD01.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 X-OriginatorOrg: softnautics.com X-MS-Exchange-CrossTenant-Network-Message-Id: de79195c-ade4-4936-53aa-08d542d2bf86 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2017 09:12:06.5516 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 17b76cff-50c6-4f7a-9198-dd4afc5f8bea X-MS-Exchange-Transport-CrossTenantHeadersStamped: BM1PR0101MB1444 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vBE9CIG4027131 Content-Length: 1108 Lines: 27 ________________________________________ > From: Joe Perches > Sent: Wednesday, December 13, 2017 9:09 PM > To: Dhaval Shah; Philippe Ombredanne > Cc: pali.rohar@gmail.com; Darren Hart; Andy Shevchenko; platform-driver-x86@vger.kernel.org; LKML > Subject: Re: [PATCH] platform/x86: dell-rbtn: Block comments use * on subsequent lines > > On Wed, 2017-12-13 at 12:41 +0000, Dhaval Shah wrote: > > > If anyone does conversions of these license texts > > > you have to be _extremely_ careful about what > > > specific license identifier you use. > > > This license includes the text > > > "or (at your option) any later version" > > > which is not the same as using > > > SPDX-License-Identifier: GPL-2.0 > > > > I have given this SPDX ID based on the current license info in the driver. > > No, you have not. > You have done it incorrectly. > > For a short description, read: > https://spdx.org/sites/cpstandard/files/pages/files/using_spdx_license_list_short_identifiers.pdf > page 5 I got your point. SPDX text should be "SPDX-License-Identifier: GPL-2.0+". Am i Right?