Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751438AbdLNJMt (ORCPT ); Thu, 14 Dec 2017 04:12:49 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:40742 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751164AbdLNJMs (ORCPT ); Thu, 14 Dec 2017 04:12:48 -0500 X-Google-Smtp-Source: ACJfBoujQ1frPiJfzW6J5XQCgIjEHKVdscHhQtPpSATDhtZE4FDpfVSV0rgE+4+DkedR2UAFJTiZn20RahyRgQizUAs= MIME-Version: 1.0 In-Reply-To: <20171214074906.2147-3-nagasure@xilinx.com> References: <20171214074906.2147-1-nagasure@xilinx.com> <20171214074906.2147-3-nagasure@xilinx.com> From: Philippe Ombredanne Date: Thu, 14 Dec 2017 10:12:06 +0100 Message-ID: Subject: Re: [PATCH v8 2/2] mtd: nand: Add support for Arasan NAND Flash Controller To: Naga Sureshkumar Relli Cc: boris.brezillon@free-electrons.com, richard@nod.at, computersforpeace@gmail.com, marek.vasut@gmail.com, cyrille.pitchen@wedev4u.fr, dwmw2@infradead.org, linux-mtd@lists.infradead.org, LKML , michals@xilinx.com, punnaia@xilinx.com, nagasuresh12@gmail.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1047 Lines: 37 Dear Naga, On Thu, Dec 14, 2017 at 8:49 AM, Naga Sureshkumar Relli wrote: > Added the basic driver for Arasan NAND Flash Controller used in > Zynq UltraScale+ MPSoC. It supports only Hw ECC and upto 24bit > correction. > > Signed-off-by: Naga Sureshkumar Relli > Signed-off-by: Punnaiah Choudary Kalluri > --- /dev/null > +++ b/drivers/mtd/nand/arasan_nand.c > @@ -0,0 +1,1020 @@ > +/* > + * Arasan NAND Flash Controller Driver > + * > + * Copyright (C) 2014 - 2017 Xilinx, Inc. > + * > + * This program is free software; you can redistribute it and/or modify it under > + * the terms of the GNU General Public License version 2 as published by the > + * Free Software Foundation; either version 2 of the License, or (at your > + * option) any later version. > + */ Could you use the new SPDX tags instead of this fine and long boilerplate? See Thomas doc for details [1] [1] https://lkml.org/lkml/2017/12/4/934 Thanks! -- Cordially Philippe Ombredanne