Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751574AbdLNLKD (ORCPT ); Thu, 14 Dec 2017 06:10:03 -0500 Received: from fllnx210.ext.ti.com ([198.47.19.17]:47124 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751422AbdLNLKC (ORCPT ); Thu, 14 Dec 2017 06:10:02 -0500 Subject: Re: [PATCH v4 3/3] PCI: endpoint: Fix find_first_zero_bit() usage To: Niklas Cassel , Lorenzo Pieralisi , Bjorn Helgaas References: <20171212141634.5985-1-niklas.cassel@axis.com> <20171212141634.5985-4-niklas.cassel@axis.com> CC: Niklas Cassel , , From: Kishon Vijay Abraham I Message-ID: <7bd08771-d860-52b6-9439-a45a1b70c6e0@ti.com> Date: Thu, 14 Dec 2017 16:39:52 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20171212141634.5985-4-niklas.cassel@axis.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 683 Lines: 21 On Tuesday 12 December 2017 07:46 PM, Niklas Cassel wrote: > find_first_zero_bit()'s parameter 'size' is defined in bits, > not in bytes. > > Calling find_first_zero_bit() with the wrong size unit > will lead to insidious bugs. > > Fix this by calling find_first_zero_bit() with size BITS_PER_LONG, > rather than sizeof() and add missing find_first_zero_bit() return > handling. > > Fixes: d74679911610 ("PCI: endpoint: Introduce configfs entry for configuring EP functions") > Signed-off-by: Niklas Cassel > Acked-by: Lorenzo Pieralisi I'll hold Acking this patch, since it is dependent on the previous one. Thanks Kishon