Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751928AbdLNLRv (ORCPT ); Thu, 14 Dec 2017 06:17:51 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:44421 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751523AbdLNLRt (ORCPT ); Thu, 14 Dec 2017 06:17:49 -0500 X-Google-Smtp-Source: ACJfBourE8PnvsG3QI34vdP1XCsbZh5cGfpCCx0m7u9p2tl5D0qyuLzf7g9aP4ehXSnyHv9OIK6HyA== Subject: Re: [PATCH v2 3/3] arm: dts: mt7623: fix card detection issue on bananapi-r2 To: sean.wang@mediatek.com, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: From: Matthias Brugger Message-ID: <14ba6eb7-c9a3-f78b-e0e2-c44846aa1f76@gmail.com> Date: Thu, 14 Dec 2017 12:17:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1123 Lines: 34 On 12/07/2017 07:43 AM, sean.wang@mediatek.com wrote: > From: Sean Wang > > Fix that bananapi-r2 booting from SD-card would fail since incorrect > polarity is applied to the previous setup with GPIO_ACTIVE_HIGH. > > Cc: stable@vger.kernel.org > Fixes: 0eed8d097612 ("arm: dts: mt7623: Add SD-card and EMMC to bananapi-r2") > Signed-off-by: Sean Wang > Tested-by: Matthias Brugger > --- > arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > index 688a863..7bf5aa2 100644 > --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > @@ -204,7 +204,7 @@ > bus-width = <4>; > max-frequency = <50000000>; > cap-sd-highspeed; > - cd-gpios = <&pio 261 0>; > + cd-gpios = <&pio 261 GPIO_ACTIVE_LOW>; > vmmc-supply = <&mt6323_vmch_reg>; > vqmmc-supply = <&mt6323_vio18_reg>; > }; > 2 and 3 pushed to v4.15-next/dts32 Thanks!