Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751973AbdLNMav (ORCPT ); Thu, 14 Dec 2017 07:30:51 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:37342 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751719AbdLNMat (ORCPT ); Thu, 14 Dec 2017 07:30:49 -0500 Date: Thu, 14 Dec 2017 13:30:37 +0100 (CET) From: Thomas Gleixner To: "Rafael J. Wysocki" cc: Linus Torvalds , Bjorn Helgaas , Maarten Lankhorst , Michal Hocko , Andy Lutomirski , Linux Kernel Mailing List , the arch/x86 maintainers , Daniel Vetter , Bjorn Helgaas , "Rafael J. Wysocki" , linux-pci@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: Linux 4.15-rc2: Regression in resume from ACPI S3 In-Reply-To: <3265333.8krWOQvcRi@aspire.rjw.lan> Message-ID: References: <168050887.sZlTFXWCmO@aspire.rjw.lan> <3265333.8krWOQvcRi@aspire.rjw.lan> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2185 Lines: 48 On Thu, 14 Dec 2017, Rafael J. Wysocki wrote: > On Thursday, December 14, 2017 12:54:05 PM CET Thomas Gleixner wrote: > > Now the graphics issue is a different story. That only happens on > > hibernation after doing the snapshot. There all non boot cpus are onlined > > again and after that the devices are 'thawed'. The following reenable of > > interrupts fails because i915 is not in PCI_D0 state. > > > > Suspend: > > > > irq_migrate_all_off_this_cpu: Mask 125 pci_msi_mask_irq+0x0/0x10 > > __pci_write_msi_msg: 0000:00:02.0 00000000fee0100c 0000412a > > __pci_write_msi_msg: Not written <- Device not in PCI_D0 > > .... > > device_pm_callback_start: i915 0000:00:02.0, parent: pci0000:00, noirq bus [resume] > > pci_pm_resume_noirq <-dpm_run_callback > > pci_pm_resume_noirq <-dpm_run_callback > > pci_pm_default_resume_early <-pci_pm_resume_noirq > > pci_pm_default_resume_early <-pci_pm_resume_noirq > > __pci_write_msi_msg: 0000:00:02.0 00000000fee0100c 0000412a <-- Set the new affinity > > device_pm_callback_end: i915 0000:00:02.0, err=0 > > So this works, because we power up the device during resume even if it > had been suspended (via runtime PM) before the suspend started. > > > Hibernate: > > > > irq_migrate_all_off_this_cpu: Mask 125 pci_msi_mask_irq+0x0/0x10 > > __pci_write_msi_msg: 0000:00:02.0 00000000fee0100c 0000412a > > __pci_write_msi_msg: Not written <- Device not in PCI_D0 > > .... > > device_pm_callback_start: i915 0000:00:02.0, parent: pci0000:00, noirq bus [thaw] > > pci_pm_thaw_noirq <-dpm_run_callback > > __pci_write_msi_msg: 0000:00:02.0 00000000fee0100c 0000412a > > __pci_write_msi_msg: Not written <--- Device is not in PCI_D0 > > device_pm_callback_end: i915 0000:00:02.0, err=0 > > And here we try to leave the device alone which is OK for devices in D0, > but not for suspended ones. > > It looks like we need to power up them at the "thaw" time too or at least > I don't see how to address that differently. The question is whether the code which brings the device out of D0 should write the message unconditionally. That would be sufficient I think. Thanks, tglx