Subject: Re: [PATCH v4 net-next 0/4] bpftool: cgroup bpf operations
To: Roman Gushchin <guro@fb.com>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com, ast@kernel.org,
        jakub.kicinski@netronome.com, kafai@fb.com,
        Quentin Monnet <quentin.monnet@netronome.com>,
        David Ahern <dsahern@gmail.com>
References: <20171213151854.21960-1-guro@fb.com>
From: Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <5f5dec26-3c2a-f101-4eae-76aa3ca9e9a5@iogearbox.net>
Date: Thu, 14 Dec 2017 13:45:24 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20171213151854.21960-1-guro@fb.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1025
Lines: 21

On 12/13/2017 04:18 PM, Roman Gushchin wrote:
> This patchset adds basic cgroup bpf operations to bpftool.
> 
> Right now there is no convenient way to perform these operations.
> The /samples/bpf/load_sock_ops.c implements attach/detacg operations,
> but only for BPF_CGROUP_SOCK_OPS programs. Bps (part of bcc) implements
> bpf introspection, but lacks any cgroup-related specific.
> 
> I find having a tool to perform these basic operations in the kernel tree
> very useful, as it can be used in the corresponding bpf documentation
> without creating additional dependencies. And bpftool seems to be
> a right tool to extend with such functionality.
> 
> v4:
>   - ATTACH_FLAGS and ATTACH_TYPE are listed and described in docs and usage
>   - ATTACH_FLAG names converted to "multi" and "override"
>   - do_attach() recognizes ATTACH_FLAG abbreviations, e.g "mul"
>   - Local variables sorted ("reverse Christmas tree")
>   - unknown attach flags value will be never truncated

Series applied to bpf-next, thanks everyone!