Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752932AbdLNOI2 (ORCPT ); Thu, 14 Dec 2017 09:08:28 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:56016 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751084AbdLNOIY (ORCPT ); Thu, 14 Dec 2017 09:08:24 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E110860BE3 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=timur@codeaurora.org Subject: Re: [PATCH v2 1/2] acpi, spcr: Make SPCR avialable to other architectures To: Lorenzo Pieralisi Cc: Prarit Bhargava , linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-serial@vger.kernel.org, Bhupesh Sharma , Lv Zheng , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Jonathan Corbet , Catalin Marinas , Will Deacon , "Rafael J. Wysocki" , graeme.gregory@linaro.org, mark.salter@redhat.com References: <20171211155059.17062-1-prarit@redhat.com> <20171211155059.17062-2-prarit@redhat.com> <20171213124533.GA32362@red-moon> <20171214103027.GB697@e107981-ln.cambridge.arm.com> From: Timur Tabi Message-ID: <6541a055-bfd4-daa7-5b91-38384bd65c3f@codeaurora.org> Date: Thu, 14 Dec 2017 08:08:08 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171214103027.GB697@e107981-ln.cambridge.arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 815 Lines: 17 On 12/14/17 4:30 AM, Lorenzo Pieralisi wrote: >> I didn't want to put any ACPI code in amba-pl011.c, so putting it in spcr.c >> made the most sense. I agree the global variable is ugly. If you have a >> better idea, I'm all ears. > I told you my idea. It could have been made easier by reusing the > ACPI_DECLARE_PROBE_ENTRY() mechanism. Sorry, I don't mean to be difficult, but when did you tell *me* this idea of yours? I don't see any email from you to me that mentions ACPI_DECLARE_PROBE_ENTRY(). I've never even heard of that macro before. Please note that I'm not the original author of this code. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.