Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752769AbdLNOw4 (ORCPT ); Thu, 14 Dec 2017 09:52:56 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:54936 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752016AbdLNOwy (ORCPT ); Thu, 14 Dec 2017 09:52:54 -0500 Date: Thu, 14 Dec 2017 17:42:15 +0300 From: Dan Carpenter To: Valentin Vidic Cc: Marcus Wolf , devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Marcin Ciupak , Marcus Wolf , Simon =?iso-8859-1?Q?Sandstr=F6m?= Subject: Re: [PATCH 6/8 v3] staging: pi433: use defines for shifting register values Message-ID: <20171214144215.zj35buhshkayopuj@mwanda> References: <20171213142156.3201-1-Valentin.Vidic@CARNet.hr> <20171213142156.3201-6-Valentin.Vidic@CARNet.hr> <70c9a1fc-31eb-27c4-1283-35590f8b80f6@smarthome-wolf.de> <20171213165514.12509-1-Valentin.Vidic@CARNet.hr> <38352026-045b-a082-93bb-10e9e70f9f55@smarthome-wolf.de> <20171213174444.21088-1-Valentin.Vidic@CARNet.hr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213174444.21088-1-Valentin.Vidic@CARNet.hr> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8744 signatures=668646 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=585 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712140203 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 617 Lines: 16 You'll need to resend everything. The thread is too messy. On Wed, Dec 13, 2017 at 06:44:44PM +0100, Valentin Vidic wrote: > diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c > index f77ecd60f43a..0889c65d5a31 100644 > --- a/drivers/staging/pi433/rf69.c > +++ b/drivers/staging/pi433/rf69.c > @@ -340,14 +340,13 @@ enum lnaGain rf69_get_lna_gain(struct spi_device *spi) The rf69_get_lna_gain() function is never called. Just delete it. Also the enum lnaGain is just a pointless abstraction which complicates the code needlessly. It will be deleted eventually too. regards, dan carpenter