Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753591AbdLNRBM (ORCPT ); Thu, 14 Dec 2017 12:01:12 -0500 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:24152 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753358AbdLNRBK (ORCPT ); Thu, 14 Dec 2017 12:01:10 -0500 X-IronPort-AV: E=Sophos;i="5.45,400,1508774400"; d="scan'208";a="65496302" From: Bart Van Assche To: "tj@kernel.org" , "axboe@kernel.dk" CC: "kernel-team@fb.com" , "linux-kernel@vger.kernel.org" , "peterz@infradead.org" , "osandov@fb.com" , "linux-block@vger.kernel.org" , "oleg@redhat.com" , "hch@lst.de" Subject: Re: [PATCH 1/6] blk-mq: protect completion path with RCU Thread-Topic: [PATCH 1/6] blk-mq: protect completion path with RCU Thread-Index: AQHTc3vmYOLb+M2ZAEiHwzccmpavxaNDE0MA Date: Thu, 14 Dec 2017 17:01:06 +0000 Message-ID: <1513270860.2475.14.camel@wdc.com> References: <20171212190134.535941-1-tj@kernel.org> <20171212190134.535941-2-tj@kernel.org> In-Reply-To: <20171212190134.535941-2-tj@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [199.255.44.171] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1536;20:pbBb8JE78SiD1KuH+d8CFS7qNYOuZtE4rU3Sb3swK3bTcl4mlERavRRaWdcyGJURn1Rq5EA6C6GWs4qj6V0AdkNamhpUFMFUM4EyzFLzWMyf1VaBzmRcIoZummqkjcrojwnzSsH3Uoh46Q8ZB1B66LdbpXqqe2JbuTjjiVPXaBU= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 7f0a376c-eb5a-4488-1f40-08d543144429 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603307);SRVR:CY1PR0401MB1536; x-ms-traffictypediagnostic: CY1PR0401MB1536: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231023)(6055026)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(20161123560025)(20161123555025)(6072148)(201708071742011);SRVR:CY1PR0401MB1536;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:CY1PR0401MB1536; x-forefront-prvs: 05214FD68E x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(346002)(396003)(39860400002)(366004)(24454002)(52544003)(377424004)(189003)(199004)(110136005)(102836003)(25786009)(68736007)(54906003)(316002)(4326008)(6436002)(3846002)(105586002)(14454004)(6116002)(81156014)(81166006)(305945005)(103116003)(7736002)(8936002)(8676002)(106356001)(72206003)(77096006)(6486002)(478600001)(5660300001)(76176011)(99286004)(3660700001)(229853002)(2906002)(2900100001)(53936002)(3280700002)(6506007)(86362001)(59450400001)(66066001)(2950100002)(4001150100001)(6512007)(2501003)(97736004)(6246003)(36756003);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1536;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f0a376c-eb5a-4488-1f40-08d543144429 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2017 17:01:06.3339 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1536 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vBEH1LgJ000824 Content-Length: 594 Lines: 17 On Tue, 2017-12-12 at 11:01 -0800, Tejun Heo wrote: > + } else { > + srcu_idx = srcu_read_lock(hctx->queue_rq_srcu); > + if (!blk_mark_rq_complete(rq)) > + __blk_mq_complete_request(rq); > + srcu_read_unlock(hctx->queue_rq_srcu, srcu_idx); Hello Tejun, The name queue_rq_srcu was chosen to reflect the original use of that structure, namely to protect .queue_rq() calls. Your patch series broadens the use of that srcu structure so I would appreciate it if it would be renamed, e.g. into "srcu". See also commit 6a83e74d214a ("blk-mq: Introduce blk_mq_quiesce_queue()"). Thanks, Bart.