Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753817AbdLNRDy (ORCPT ); Thu, 14 Dec 2017 12:03:54 -0500 Received: from mail-yb0-f196.google.com ([209.85.213.196]:34634 "EHLO mail-yb0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753451AbdLNRDw (ORCPT ); Thu, 14 Dec 2017 12:03:52 -0500 X-Google-Smtp-Source: ACJfBov78EZpV96b2m+5gqDKupWvQYS4Pf5i5Hes+H7NdLLfiK0bncgoaj40OmNeP2YDB7CY4TesGlX2x3UcRxOc52k= MIME-Version: 1.0 In-Reply-To: <20171214165414.28225-1-malat@debian.org> References: <20171214165414.28225-1-malat@debian.org> From: Max Filippov Date: Thu, 14 Dec 2017 09:03:51 -0800 Message-ID: Subject: Re: [PATCH] xtensa: dts: Remove leading 0x and 0s from bindings notation To: Mathieu Malaterre Cc: Rob Herring , Mark Rutland , Chris Zankel , "devicetree@vger.kernel.org" , "linux-xtensa@linux-xtensa.org" , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1593 Lines: 42 Hi Mathieu, On Thu, Dec 14, 2017 at 8:54 AM, Mathieu Malaterre wrote: > Improve the DTS files by removing all the leading "0x" and zeros to fix the > following dtc warnings: > > Warning (unit_address_format): Node /XXX unit name should not have leading "0x" > > and > > Warning (unit_address_format): Node /XXX unit name should not have leading 0s > > Converted using the following command: > > find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -E -i -e "s/@0x([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" -e "s/@0+([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" {} + > > For simplicity, two sed expressions were used to solve each warnings separately. > > To make the regex expression more robust a few other issues were resolved, > namely setting unit-address to lower case, and adding a whitespace before the > the opening curly brace: > > https://elinux.org/Device_Tree_Linux#Linux_conventions > > This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation") > > Reported-by: David Daney > Suggested-by: Rob Herring > Signed-off-by: Mathieu Malaterre > --- > arch/xtensa/boot/dts/csp.dts | 2 +- > arch/xtensa/boot/dts/xtfpga-flash-128m.dtsi | 10 +++++----- > arch/xtensa/boot/dts/xtfpga-flash-16m.dtsi | 10 +++++----- > arch/xtensa/boot/dts/xtfpga-flash-4m.dtsi | 6 +++--- > arch/xtensa/boot/dts/xtfpga.dtsi | 10 +++++----- > 5 files changed, 19 insertions(+), 19 deletions(-) Acked-by: Max Filippov -- Thanks. -- Max